From 76d87087e702fc3165f9e209983f7cc0ec955d42 Mon Sep 17 00:00:00 2001 From: Kanthi Subramanian Date: Fri, 13 Nov 2026 22:38:49 +0100 Subject: [PATCH] Fix stale assertion in test_create_table_engine_backend_mismatch_rejected --- tests/integration/test_database_glue/test.py | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/tests/integration/test_database_glue/test.py b/tests/integration/test_database_glue/test.py index b1239edc94051..f5d4d2027619d 100644 --- a/tests/integration/test_database_glue/test.py +++ b/tests/integration/test_database_glue/test.py @@ -1050,7 +1050,6 @@ def test_create_table_engine_backend_mismatch_rejected(started_cluster): "IcebergAzure('http://acc.blob.core.windows.net/cont/tbl/', 'acc', 'key')", "IcebergLocal('/var/lib/clickhouse/user_files/tbl/')", "IcebergHDFS('hdfs://namenode:9000/tbl/')", - "Iceberg('/var/lib/clickhouse/user_files/tbl/') SETTINGS disk = 'local_blob_disk'", ]: error = node.query_and_get_error( f"CREATE TABLE {CATALOG_NAME}.`{root_namespace}.mismatch` (x String) ENGINE = {engine}", @@ -1064,6 +1063,21 @@ def test_create_table_engine_backend_mismatch_rejected(started_cluster): ), error assert "stores tables on S3" in error, error + # A table-level `disk` setting that differs from the catalog's value is rejected + # earlier, by the per-setting validation in DatabaseDataLake::validateCreateTableEngine, + # before the storage backend mismatch is checked. + error = node.query_and_get_error( + f"CREATE TABLE {CATALOG_NAME}.`{root_namespace}.mismatch` (x String) ENGINE = Iceberg('/var/lib/clickhouse/user_files/tbl/') SETTINGS disk = 'local_blob_disk'", + settings={ + "allow_experimental_database_glue_catalog": 1, + "allow_database_glue_catalog": 1, + }, + ) + assert ( + "Table setting `disk` differs from its value in this DataLakeCatalog" in error + ), error + assert "would be lost" in error, error + def test_schema_evolution(started_cluster): node = started_cluster.instances["node1"]