From 1f6339626a414a03a7637a598648f21bce2cf7a9 Mon Sep 17 00:00:00 2001 From: Uwe Siems Date: Thu, 12 Nov 2026 18:03:36 +0100 Subject: [PATCH 1/4] Do not create shell classes because of protected functions or field accessors - those were not created in the shell classes, and the shell classes were not used for that (this might be a remnant of the original Java wrapper generator). Instead require additionally that the destructor is virtual. Otherwise the wrong destructor will be called for objects created from Python. --- generator/abstractmetalang.cpp | 11 +++++++++-- generator/abstractmetalang.h | 1 + 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/generator/abstractmetalang.cpp b/generator/abstractmetalang.cpp index d565e7266..dbf6a037d 100644 --- a/generator/abstractmetalang.cpp +++ b/generator/abstractmetalang.cpp @@ -1154,8 +1154,10 @@ bool AbstractMetaClass::hasProtectedFunctions() const bool AbstractMetaClass::generateShellClass() const { return typeEntry()->shouldCreateShell() + // require that classes that get a shell have a virtual destructor + // (required for proper working of derived class) && (m_force_shell_class - || (!isFinal() && (hasVirtualFunctions() || hasProtectedFunctions() || hasFieldAccessors()))); + || (!isFinal() && hasVirtualDestructor() && (hasVirtualFunctions() || hasProtectedConstructors()))); } QPropertySpec* AbstractMetaClass::propertySpecForRead(const QString& name) const @@ -1312,7 +1314,12 @@ const AbstractMetaFunction* AbstractMetaField::getter() const bool AbstractMetaClass::hasConstructors() const { - return queryFunctions(Constructors).size() != 0; + return queryFunctions(Constructors).size() > 0; +} + +bool AbstractMetaClass::hasProtectedConstructors() const +{ + return queryFunctions(Constructors | WasProtected).size() > 0; } void AbstractMetaClass::addDefaultConstructor() diff --git a/generator/abstractmetalang.h b/generator/abstractmetalang.h index 6e62499b7..59a2ad321 100644 --- a/generator/abstractmetalang.h +++ b/generator/abstractmetalang.h @@ -697,6 +697,7 @@ class AbstractMetaClass : public AbstractMetaAttributes bool hasSignal(const AbstractMetaFunction* f) const; bool hasConstructors() const; + bool hasProtectedConstructors() const; void addDefaultConstructor(); From 3655a2fa99395d00f25f7f0d6acc9b8f2b6ea529 Mon Sep 17 00:00:00 2001 From: Uwe Siems Date: Thu, 12 Nov 2026 18:04:39 +0100 Subject: [PATCH 2/4] Field accessors are only generated for public members (this method isn't currently used anymore, though) --- generator/abstractmetalang.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/generator/abstractmetalang.cpp b/generator/abstractmetalang.cpp index dbf6a037d..6ed6b3a11 100644 --- a/generator/abstractmetalang.cpp +++ b/generator/abstractmetalang.cpp @@ -1066,7 +1066,7 @@ void AbstractMetaClass::setFunctions(const AbstractMetaFunctionList& functions) bool AbstractMetaClass::hasFieldAccessors() const { for (const AbstractMetaField* field : fields()) { - if (field->getter() || field->setter()) + if (field->isPublic() && (field->getter() || field->setter())) return true; } From e6e29ec9699b052b3bc68d87ebbf06508e25dde3 Mon Sep 17 00:00:00 2001 From: Uwe Siems Date: Thu, 12 Nov 2026 18:06:57 +0100 Subject: [PATCH 3/4] Remember/re-use the result of AbstractMetaClass::generateShellClass() --- generator/shellheadergenerator.cpp | 10 +++++----- generator/shellimplgenerator.cpp | 8 +++----- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/generator/shellheadergenerator.cpp b/generator/shellheadergenerator.cpp index ce8fb6448..d0ef5a7a7 100644 --- a/generator/shellheadergenerator.cpp +++ b/generator/shellheadergenerator.cpp @@ -135,7 +135,8 @@ void ShellHeaderGenerator::write(QTextStream& s, const AbstractMetaClass* meta_c } // Shell------------------------------------------------------------------- - if (meta_class->generateShellClass() && !ctors.isEmpty()) { + bool generateShell = meta_class->generateShellClass() && !ctors.isEmpty(); + if (generateShell) { AbstractMetaFunctionList virtualsForShell = getVirtualFunctionsForShell(meta_class); @@ -348,12 +349,12 @@ void ShellHeaderGenerator::write(QTextStream& s, const AbstractMetaClass* meta_c } } s << "public Q_SLOTS:" << Qt::endl; - if (meta_class->generateShellClass() || !meta_class->isAbstract()) { + if (generateShell || !meta_class->isAbstract()) { bool copyConstructorSeen = false; bool defaultConstructorSeen = false; for (const AbstractMetaFunction* fun : ctors) { - if (fun->isAbstract() || (!meta_class->generateShellClass() && !fun->isPublic())) { + if (fun->isAbstract() || (!generateShell && !fun->isPublic())) { continue; } @@ -373,8 +374,7 @@ void ShellHeaderGenerator::write(QTextStream& s, const AbstractMetaClass* meta_c if (meta_class->typeEntry()->isValue() && !copyConstructorSeen && defaultConstructorSeen && !meta_class->typeEntry()->hasNoCopy()) { - QString className = - meta_class->generateShellClass() ? shellClassName(meta_class) : meta_class->qualifiedCppName(); + QString className = generateShell ? shellClassName(meta_class) : meta_class->qualifiedCppName(); s << meta_class->qualifiedCppName() << "* new_" << meta_class->name() << "(const " << meta_class->qualifiedCppName() << "& other) {" << Qt::endl; s << className << "* a = new " << className << "();" << Qt::endl; diff --git a/generator/shellimplgenerator.cpp b/generator/shellimplgenerator.cpp index 38d18d3c1..f3d8c3f66 100644 --- a/generator/shellimplgenerator.cpp +++ b/generator/shellimplgenerator.cpp @@ -228,11 +228,11 @@ void ShellImplGenerator::write(QTextStream& s, const AbstractMetaClass* meta_cla } } - if (meta_class->generateShellClass() || !meta_class->isAbstract()) { + if (generateShell || !meta_class->isAbstract()) { // write constructors for (const AbstractMetaFunction* ctor : ctors) { - if (ctor->isAbstract() || (!meta_class->generateShellClass() && !ctor->isPublic())) { + if (ctor->isAbstract() || (!generateShell && !ctor->isPublic())) { continue; } @@ -241,8 +241,7 @@ void ShellImplGenerator::write(QTextStream& s, const AbstractMetaClass* meta_cla writeFunctionSignature(s, ctor, 0, "new_", Option(AddOwnershipTemplates | ShowStatic)); s << Qt::endl; s << "{ " << Qt::endl; - s << "return new " - << (meta_class->generateShellClass() ? shellClassName(meta_class) : meta_class->qualifiedCppName()) << "("; + s << "return new " << (generateShell ? shellClassName(meta_class) : meta_class->qualifiedCppName()) << "("; AbstractMetaArgumentList args = ctor->arguments(); for (int i = 0; i < args.size(); ++i) { if (i > 0) @@ -333,7 +332,6 @@ void ShellImplGenerator::write(QTextStream& s, const AbstractMetaClass* meta_cla } } else { if (fun->wasProtected()) { - //|| (fun->isVirtual() && meta_class->typeEntry()->shouldCreatePromoter())) { s << " ((" << promoterClassName(meta_class) << "*)theWrappedObject)->promoted_"; } else { s << " theWrappedObject->"; From b3f319d724a6c6325b2139490a299bbccced5ebf Mon Sep 17 00:00:00 2001 From: Uwe Siems Date: Mon, 16 Nov 2026 12:54:03 +0100 Subject: [PATCH 4/4] Remove a bunch of unused methods --- generator/abstractmetalang.cpp | 131 --------------------------------- generator/abstractmetalang.h | 35 --------- 2 files changed, 166 deletions(-) diff --git a/generator/abstractmetalang.cpp b/generator/abstractmetalang.cpp index 6ed6b3a11..1b20125c6 100644 --- a/generator/abstractmetalang.cpp +++ b/generator/abstractmetalang.cpp @@ -875,103 +875,6 @@ QList AbstractMetaClass::referenceCounts() const return returned; } -/******************************************************************************* - * Returns a list of all the functions retrieved during parsing which should - * be added to the Java API. - */ -AbstractMetaFunctionList AbstractMetaClass::functionsInTargetLang() const -{ - int default_flags = NormalFunctions | Visible | NotRemovedFromTargetLang; - - // Interfaces don't implement functions - default_flags |= isInterface() ? 0 : ClassImplements; - - // Only public functions in final classes - // default_flags |= isFinal() ? WasPublic : 0; - int public_flags = isFinal() ? WasPublic : 0; - - // Constructors - AbstractMetaFunctionList returned = queryFunctions(Constructors | default_flags | public_flags); - - // Final functions - returned += queryFunctions(FinalInTargetLangFunctions | NonStaticFunctions | default_flags | public_flags); - - // Virtual functions - returned += queryFunctions(VirtualInTargetLangFunctions | NonStaticFunctions | default_flags | public_flags); - - // Static functions - returned += queryFunctions(StaticFunctions | default_flags | public_flags); - - // Empty, private functions, since they aren't caught by the other ones - returned += queryFunctions(Empty | Invisible); - - return returned; -} - -AbstractMetaFunctionList AbstractMetaClass::virtualFunctions() const -{ - const AbstractMetaFunctionList list = functionsInShellClass(); - - AbstractMetaFunctionList returned; - for (AbstractMetaFunction* f : list) { - if (!f->isFinalInCpp() || f->isVirtualSlot()) - returned += f; - } - - return returned; -} - -AbstractMetaFunctionList AbstractMetaClass::nonVirtualShellFunctions() const -{ - AbstractMetaFunctionList list = functionsInShellClass(); - AbstractMetaFunctionList returned; - for (AbstractMetaFunction* f : list) { - if (f->isFinalInCpp() && !f->isVirtualSlot()) - returned += f; - } - - return returned; -} - -/******************************************************************************* - * Returns a list of all functions that should be declared and implemented in - * the shell class which is generated as a wrapper on top of the actual C++ class - */ -AbstractMetaFunctionList AbstractMetaClass::functionsInShellClass() const -{ - // Only functions and only protected and public functions - int default_flags = NormalFunctions | Visible | WasVisible | NotRemovedFromShell; - - // All virtual functions - AbstractMetaFunctionList returned = queryFunctions(VirtualFunctions | default_flags); - - // All functions explicitly set to be implemented by the shell class - // (mainly superclass functions that are hidden by other declarations) - returned += queryFunctions(ForcedShellFunctions | default_flags); - - // All functions explicitly set to be virtual slots - returned += queryFunctions(VirtualSlots | default_flags); - - return returned; -} - -/******************************************************************************* - * Returns a list of all functions that require a public override function to - * be generated in the shell class. This includes all functions that were originally - * protected in the superclass. - */ -AbstractMetaFunctionList AbstractMetaClass::publicOverrideFunctions() const -{ - return queryFunctions(NormalFunctions | WasProtected | FinalInCppFunctions | NotRemovedFromTargetLang) - + queryFunctions(Signals | WasProtected | FinalInCppFunctions | NotRemovedFromTargetLang); -} - -AbstractMetaFunctionList AbstractMetaClass::virtualOverrideFunctions() const -{ - return queryFunctions(NormalFunctions | NonEmptyFunctions | Visible | VirtualInCppFunctions | NotRemovedFromShell) - + queryFunctions(Signals | NonEmptyFunctions | Visible | VirtualInCppFunctions | NotRemovedFromShell); -} - void AbstractMetaClass::sortFunctions() { std::sort(m_functions.begin(), m_functions.end(), function_sorter); @@ -1063,16 +966,6 @@ void AbstractMetaClass::setFunctions(const AbstractMetaFunctionList& functions) #endif } -bool AbstractMetaClass::hasFieldAccessors() const -{ - for (const AbstractMetaField* field : fields()) { - if (field->isPublic() && (field->getter() || field->setter())) - return true; - } - - return false; -} - bool AbstractMetaClass::hasDefaultToStringFunction() const { for (AbstractMetaFunction* f : queryFunctionsByName("toString")) { @@ -1137,20 +1030,6 @@ bool AbstractMetaClass::hasFunction(const QString& str) const return false; } -/* Returns true if this class has one or more functions that are - protected. If a class has protected members we need to generate a - shell class with public accessors to the protected functions, so - they can be called from the native functions. -*/ -bool AbstractMetaClass::hasProtectedFunctions() const -{ - for (AbstractMetaFunction* func : m_functions) { - if (func->isProtected()) - return true; - } - return false; -} - bool AbstractMetaClass::generateShellClass() const { return typeEntry()->shouldCreateShell() @@ -1479,16 +1358,6 @@ AbstractMetaFunctionList AbstractMetaClass::queryFunctions(uint query) const return functions; } -bool AbstractMetaClass::hasInconsistentFunctions() const -{ - return cppInconsistentFunctions().size() > 0; -} - -bool AbstractMetaClass::hasSignals() const -{ - return cppSignalFunctions().size() > 0; -} - /** * Adds the specified interface to this class by adding all the * functions in the interface to this class. diff --git a/generator/abstractmetalang.h b/generator/abstractmetalang.h index 59a2ad321..050ec6f57 100644 --- a/generator/abstractmetalang.h +++ b/generator/abstractmetalang.h @@ -712,16 +712,6 @@ class AbstractMetaClass : public AbstractMetaAttributes void setDestructorException(const QString& exception) { m_destructor_exception = exception; } AbstractMetaFunctionList queryFunctionsByName(const QString& name) const; AbstractMetaFunctionList queryFunctions(uint query) const; - inline AbstractMetaFunctionList allVirtualFunctions() const; - inline AbstractMetaFunctionList allFinalFunctions() const; - AbstractMetaFunctionList functionsInTargetLang() const; - AbstractMetaFunctionList functionsInShellClass() const; - inline AbstractMetaFunctionList cppInconsistentFunctions() const; - inline AbstractMetaFunctionList cppSignalFunctions() const; - AbstractMetaFunctionList publicOverrideFunctions() const; - AbstractMetaFunctionList virtualOverrideFunctions() const; - AbstractMetaFunctionList virtualFunctions() const; - AbstractMetaFunctionList nonVirtualShellFunctions() const; AbstractMetaFieldList fields() const { return m_fields; } void setFields(const AbstractMetaFieldList& fields) { m_fields = fields; } @@ -761,8 +751,6 @@ class AbstractMetaClass : public AbstractMetaAttributes bool isQtNamespace() const { return isNamespace() && name() == "Qt"; } QString qualifiedCppName() const { return m_type_entry->qualifiedCppName(); } - bool hasInconsistentFunctions() const; - bool hasSignals() const; bool inheritsFrom(const AbstractMetaClass* other) const; void setForceShellClass(bool on) { m_force_shell_class = on; } @@ -770,13 +758,10 @@ class AbstractMetaClass : public AbstractMetaAttributes bool hasVirtualSlots() const { return m_has_virtual_slots; } bool hasVirtualFunctions() const { return !isFinal() && m_has_virtuals; } - bool hasProtectedFunctions() const; QList templateArguments() const { return m_template_args; } void setTemplateArguments(const QList& args) { m_template_args = args; } - bool hasFieldAccessors() const; - // only valid during metajavabuilder's run QStringList baseClassNames() const { return m_base_class_names; } void setBaseClassNames(const QStringList& names) { m_base_class_names = names; } @@ -932,24 +917,4 @@ class QPropertySpec int m_index {-1}; }; -inline AbstractMetaFunctionList AbstractMetaClass::allVirtualFunctions() const -{ - return queryFunctions(VirtualFunctions | NotRemovedFromTargetLang); -} - -inline AbstractMetaFunctionList AbstractMetaClass::allFinalFunctions() const -{ - return queryFunctions(FinalInTargetLangFunctions | FinalInCppFunctions | NotRemovedFromTargetLang); -} - -inline AbstractMetaFunctionList AbstractMetaClass::cppInconsistentFunctions() const -{ - return queryFunctions(Inconsistent | NormalFunctions | Visible | NotRemovedFromTargetLang); -} - -inline AbstractMetaFunctionList AbstractMetaClass::cppSignalFunctions() const -{ - return queryFunctions(Signals | Visible | NotRemovedFromTargetLang); -} - #endif // ABSTRACTMETALANG_H