From d76468d1b161eb77333f9cee426f26326adebf8d Mon Sep 17 00:00:00 2001 From: georgeRobertson <50412379+georgeRobertson@users.noreply.github.com> Date: Tue, 3 Nov 2026 16:11:27 +0000 Subject: [PATCH] fix: ensure empty string rather than None or entity name is present in report for Data Item Submission Name add Empty Entity to category as well for consistency with other entity check validations --- src/dve/core_engine/backends/base/reader.py | 3 ++- src/dve/pipeline/pipeline.py | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/dve/core_engine/backends/base/reader.py b/src/dve/core_engine/backends/base/reader.py index eeeca7f..97cc710 100644 --- a/src/dve/core_engine/backends/base/reader.py +++ b/src/dve/core_engine/backends/base/reader.py @@ -165,9 +165,10 @@ def read_to_entity_type( entity=entity_name, record=None, failure_type="submission", - error_location=entity_name, error_code=config.error_code, error_message=config.error_message, + error_type="submission", + category="Empty entity", ) ], ) diff --git a/src/dve/pipeline/pipeline.py b/src/dve/pipeline/pipeline.py index 53185a0..66f5f85 100644 --- a/src/dve/pipeline/pipeline.py +++ b/src/dve/pipeline/pipeline.py @@ -930,6 +930,7 @@ def _get_error_dataframes(self, submission_id: str, include_record_rejections: b pl.col(column).cast(ERROR_SCHEMA[column]) # type: ignore for column in df.columns ) + df = df.with_columns(pl.col("Data_Item").fill_null("")) df = df.sort("Type", descending=False) # type: ignore errors_dfs.append(df)