Repository navigation
refactor: tighten execution facade and platform_http template - #785
Merged
Merged
Conversation
Expand execution re-exports, document Wave2 thin-main rules, and guard facade imports with a focused pytest plus a tighter common line budget. Co-authored-by: Cursor <cursoragent@cursor.com>
Pigbibi
added
risk:low
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Pigbibi
added
agent-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Cursor Auto (Composer) in a local agent session for QuantStrategyLab untangle Wave3.
What changed
execution/re-exports (fills, capabilities, guarded ports, order status, runtime-loaded receipts).execution_kernel/platform_http.py.check_common_facade_imports.py+tests/test_common_facade_imports.py).How verified
PYTHONPATH=src python3 scripts/check_common_facade_imports.pyPYTHONPATH=src python3 -m pytest -q tests/test_common_facade_imports.pyPYTHONPATH=src python3 -m pytest -q tests/test_execution_fills.py tests/test_risk_guarded_execution_port.py(70 passed)python3 scripts/check_style.py --phase 2(0 blocking)Why
Wave3 consolidates QPK facades after #782 so platforms prefer focused imports and share one thin-main template.
Risk
risk:low— structure/docs/guards only; no intentional order or HTTP contract change.Made with Cursor