Repository navigation
fix(catalogue): pass the mem0 session date as the timestamp mem0's fix reads - #29
Merged
Merged
Conversation
Mem0's open fix for its Observation Date (mem0ai/mem0#4963) reads the date from metadata["timestamp"]. The adapter passed it only as metadata["date"], so a pin bump alone would not reach extraction. Mem0 2.2.1 ignores the key; scores do not change until the pin moves.
This comment has been minimized.
This comment has been minimized.
aitianshi
changed the title
aitianshi
added a commit
that referenced
this pull request
Nov 10, 2026
## What Pull request titles become conventional commit subjects, `type(scope): summary`. The repository squash-merges with the PR title as the commit subject, so the title is what `main`'s history shows. AGENTS.md states the rule with its types (`feat`, `fix`, `perf`, `refactor`, `docs`, `test`, `ci`, `build`, `chore`, `revert`) and scopes (the parts of Nullius), and the `/file-issue` skill, which assistants use to open PRs, applies it. No check enforces it. ## Touches docs and site · CI and skills ## Verified - Backend suite `python3 app/tests/parallel.py`, OK. - The open PRs #29, #30, #32 and #34 already use the form. ## Risk Documentation only; earlier commit subjects on `main` are not rewritten. Undone by a revert.
This comment has been minimized.
This comment has been minimized.
🟡 PR judge · 5 of 7 yes · #29 ↔ #12
Acceptance criteria, 1 of 2 met
Checks the script runs itself, 4 of 4 pass
|
Collaborator
Author
|
Extraction is supported in Nullius, but it needs to be supported in |
Open
1 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #12 (it stays open until a mem0 release carries the upstream fix)
What
Mem0's open-source
adddates extracted facts by the day of the run, because it never fills its extraction prompt's Observation Date (mem0ai/mem0#4963, fixes open in mem0ai/mem0#6781 and mem0ai/mem0#5949). Both upstream fixes read that date frommetadata["timestamp"]; our adapter passed the session date only asmetadata["date"], so bumping the pin would not have reached extraction. The adapter now passes a dated session's date undertimestampas well (undated sessions get none, so Mem0 keeps its default). Mem0 2.2.1 ignores it. Mem0 is not patched or wrapped.Touches
catalogue
Verified
app/tests/test_mem0_capability.py: with a stand-in for Mem0, a dated session sendstimestampequal to its date; an undated one sends none.python3 app/tests/parallel.py, OK.Risk
Low. Mem0 2.2.1 stores
timestampas ordinary metadata; recall still showsdate. If a later Mem0 parsestimestampstrictly, LongMemEval's2023/05/21 (Sun) 16:22format could be rejected; that would surface when the pin is bumped, and the change is undone by reverting this commit.