From 4b47fa831eccf0a2d3c7c3aacb78532f93bffbb9 Mon Sep 17 00:00:00 2001 From: Pietro Montorfano Date: Wed, 18 Nov 2026 10:33:57 +0100 Subject: [PATCH 1/5] feat(create-modal): pick a parent item when creating a work item The heading of the create modal becomes a searchable picker over the selected workspace. Picking an item creates the new one as its child and restricts the type field to valid child types. --- .gitignore | 1 + frontend/src/lib/dialogs/CreateModal.svelte | 111 ++++++++++++++++++-- frontend/src/lib/locales/en/misc.js | 1 + frontend/src/lib/locales/it/misc.js | 1 + frontend/src/lib/pickers/ChipPicker.svelte | 7 +- frontend/src/lib/utils/hierarchy.js | 4 + frontend/src/lib/utils/hierarchy.spec.js | 27 +++++ 7 files changed, 141 insertions(+), 11 deletions(-) create mode 100644 frontend/src/lib/utils/hierarchy.spec.js diff --git a/.gitignore b/.gitignore index 429a9622b..ec38bd902 100644 --- a/.gitignore +++ b/.gitignore @@ -37,6 +37,7 @@ cx !frontend/src/lib/stores/i18n-utils.spec.js !frontend/src/lib/mobile/mobile-i18n.spec.js !frontend/scripts/hardcoded-i18n-ast.spec.js +!frontend/src/lib/utils/hierarchy.spec.js !frontend/src/lib/api/integrations.spec.js !frontend/src/lib/features/items/zammadPanelContext.spec.js !frontend/src/lib/features/items/ZammadLinkResolver.spec.js diff --git a/frontend/src/lib/dialogs/CreateModal.svelte b/frontend/src/lib/dialogs/CreateModal.svelte index fc897ef2c..f14d00d16 100644 --- a/frontend/src/lib/dialogs/CreateModal.svelte +++ b/frontend/src/lib/dialogs/CreateModal.svelte @@ -10,8 +10,11 @@ import { workspacePermissions } from '../stores/workspacePermissions.svelte.js'; import { packs as packsApi } from '../api/packs.js'; import { workspaces } from '../api/workspaces.js'; - import { attachments } from '../api/misc.js'; + import { attachments, search } from '../api/misc.js'; import { items } from '../api/items.js'; + import ItemTypeIcon from '../components/ItemTypeIcon.svelte'; + import ItemKey from '../components/ItemKey.svelte'; + import { childItemTypesForParent, canHaveChildren } from '../utils/hierarchy.js'; import { collections } from '../api/collections.js'; import X from '@lucide/svelte/icons/x'; import Target from '@lucide/svelte/icons/target'; @@ -130,6 +133,65 @@ let collectionCategoryId = $state(null); let submitting = $state(false); + // Parent chosen from the header picker (as opposed to a pre-set parent context). + const NO_PARENT = '__none__'; + let parentPickedHere = $state(false); + let parentSearchResults = $state([]); + let parentSearchTimer; + let parentSearchController; + let pickedParent = $state(null); + let parentItems = $derived([ + { id: NO_PARENT, title: t('createModal.noParentOption') }, + ...(pickedParent && !parentSearchResults.some((r) => r.id === pickedParent.id) ? [pickedParent] : []), + ...parentSearchResults + ]); + + function resetParentSearch() { + clearTimeout(parentSearchTimer); + parentSearchController?.abort(); + parentSearchResults = []; + } + + function onParentSearchChange(query) { + resetParentSearch(); + const workspaceId = workItemFormStore.formData.workspace_id; + if (!workspaceId || query.trim().length < 2) return; + parentSearchTimer = setTimeout(async () => { + const controller = new AbortController(); + parentSearchController = controller; + try { + const results = await search.items({ query, workspaceIds: [workspaceId], limit: 20, signal: controller.signal }); + if (controller.signal.aborted) return; + const types = workItemFormStore.itemTypes; + parentSearchResults = (results || []) + .filter((r) => canHaveChildren(types, types.find((ty) => ty.id === r.item_type_id))) + .slice(0, 10); + } catch (error) { + if (!controller.signal.aborted) errorToast(error?.message || String(error)); + } + }, 300); + } + + function selectParent(item) { + if (item.id === NO_PARENT) { + clearPickedParent(); + return; + } + const type = workItemFormStore.itemTypes.find((ty) => ty.id === item.item_type_id); + pickedParent = item; + parentPickedHere = true; + workItemFormStore.setParentItem( + { id: item.id, title: item.title }, + childItemTypesForParent(workItemFormStore.itemTypes, type) + ); + } + + function clearPickedParent() { + pickedParent = null; + parentPickedHere = false; + workItemFormStore.setParentItem(null, null); + } + // The work-item create endpoint requires item.create in the target // workspace (denied with 404), so the picker must only offer workspaces // where creation is allowed. Mirrors CollectionBoard's quick-add filter; @@ -174,6 +236,9 @@ isOpen = false; selectedType = initialType; recoverableItemId = null; + parentPickedHere = false; + pickedParent = null; + resetParentSearch(); // Reset work item form store workItemFormStore.resetForm(); @@ -541,7 +606,7 @@ {#snippet header()} - {#if !workItemFormStore.parentItem && !compactMode} + {#if (!workItemFormStore.parentItem || parentPickedHere) && !compactMode} - {#if selectedType === 'work-item' && !workItemFormStore.parentItem} + {#if selectedType === 'work-item' && (!workItemFormStore.parentItem || parentPickedHere)} { if (workspace) { + if (parentPickedHere && workspace.id !== workItemFormStore.formData.workspace_id) clearPickedParent(); workItemFormStore.setWorkspace(workspace); } }} @@ -607,13 +673,38 @@ {/if} - - {#if workItemFormStore.parentItem} - {t('createModal.newChildItem')} - {:else} - {t('createModal.new')} {currentTypeName} - {/if} - + {#if selectedType === 'work-item' && (!workItemFormStore.parentItem || parentPickedHere)} + p.id} + getLabel={(p) => p.id === NO_PARENT ? '' : p.title} + placeholder={`${t('createModal.new')} ${currentTypeName}`} + searchable={true} + testId="create-parent-chip" + onSearchChange={onParentSearchChange} + onSelect={selectParent} + > + {#snippet itemSnippet({ item })} + {#if item.id === NO_PARENT} + {item.title} + {:else} + {@const itemType = workItemFormStore.itemTypes.find((ty) => ty.id === item.item_type_id)} + {#if itemType}{/if} + + {item.title} + {/if} + {/snippet} + + {:else} + + {#if workItemFormStore.parentItem} + {t('createModal.newChildItem')} + {:else} + {t('createModal.new')} {currentTypeName} + {/if} + + {/if}