From ba9e84c4916ff815dbceb2c0d53b7d70deaa4536 Mon Sep 17 00:00:00 2001 From: madhur310 Date: Wed, 4 Nov 2026 14:40:50 -0800 Subject: [PATCH] fix(ctc): drop unused pnpm cache config from ctcOpen/ctcClose - W-24787945 Neither workflow runs a dependency install via the caller's package manager (only a global `npm install -g @salesforce/change-case-management`), so the pnpm store setup-node tried to cache was never populated. This made the cache-save post-step fail with "Path Validation Error: Path(s) specified in the action for caching do(es) not exist" on every run, marking the job red even though the actual CTC case create/close always succeeded. --- .github/workflows/ctcClose.yml | 23 ----------------------- .github/workflows/ctcOpen.yml | 23 ----------------------- 2 files changed, 46 deletions(-) diff --git a/.github/workflows/ctcClose.yml b/.github/workflows/ctcClose.yml index 42c0671..9d5085d 100644 --- a/.github/workflows/ctcClose.yml +++ b/.github/workflows/ctcClose.yml @@ -15,21 +15,6 @@ on: type: string default: lts/* required: false - package-manager: - description: Package manager used by the calling repository (npm, pnpm, or yarn) - type: string - default: npm - required: false - package-manager-version: - description: pnpm version to use when package-manager is pnpm. Leave empty to let pnpm/action-setup read the "packageManager" field from the caller's package.json instead. - type: string - default: '' - required: false - cache-dependency-path: - description: Path to the calling repository's package manager lockfile; auto-derived from package-manager if not set - type: string - default: '' - required: false jobs: ctcClose: @@ -37,17 +22,9 @@ jobs: steps: - uses: actions/checkout@v4 - - name: Setup pnpm - if: inputs.package-manager == 'pnpm' - uses: pnpm/action-setup@v4 - with: - version: ${{ inputs.package-manager-version }} - - uses: actions/setup-node@v4 with: node-version: ${{ inputs.nodeVersion }} - cache: ${{ inputs.package-manager }} - cache-dependency-path: ${{ inputs.cache-dependency-path || (inputs.package-manager == 'yarn' && 'yarn.lock' || (inputs.package-manager == 'pnpm' && 'pnpm-lock.yaml' || 'package-lock.json')) }} - run: npm install -g @salesforce/change-case-management --omit=dev - id: ctc run: | diff --git a/.github/workflows/ctcOpen.yml b/.github/workflows/ctcOpen.yml index f42ac97..a68561c 100644 --- a/.github/workflows/ctcOpen.yml +++ b/.github/workflows/ctcOpen.yml @@ -9,21 +9,6 @@ on: type: string default: lts/* required: false - package-manager: - description: Package manager used by the calling repository (npm, pnpm, or yarn) - type: string - default: npm - required: false - package-manager-version: - description: pnpm version to use when package-manager is pnpm. Leave empty to let pnpm/action-setup read the "packageManager" field from the caller's package.json instead. - type: string - default: '' - required: false - cache-dependency-path: - description: Path to the calling repository's package manager lockfile; auto-derived from package-manager if not set - type: string - default: '' - required: false outputs: changeCaseId: description: Id for the change case created @@ -37,17 +22,9 @@ jobs: steps: - uses: actions/checkout@v4 - - name: Setup pnpm - if: inputs.package-manager == 'pnpm' - uses: pnpm/action-setup@v4 - with: - version: ${{ inputs.package-manager-version }} - - uses: actions/setup-node@v4 with: node-version: ${{ inputs.nodeVersion }} - cache: ${{ inputs.package-manager }} - cache-dependency-path: ${{ inputs.cache-dependency-path || (inputs.package-manager == 'yarn' && 'yarn.lock' || (inputs.package-manager == 'pnpm' && 'pnpm-lock.yaml' || 'package-lock.json')) }} - run: npm install -g @salesforce/change-case-management --omit=dev