From b2dedcefa0038d859d32e12e3056586dc169a301 Mon Sep 17 00:00:00 2001 From: madhur310 Date: Thu, 5 Nov 2026 11:38:21 -0800 Subject: [PATCH] fix(release): remove dead ctcOpen/ctcClose args from npmPublish.yml PR #205 dropped package-manager, package-manager-version, and cache-dependency-path from ctcOpen.yml/ctcClose.yml's inputs. Those workflows never installed the caller's dependencies with them (only a global npm install -g @salesforce/change-case-management); the inputs only selected a setup-node cache key, and since nothing ever populated that cache, pnpm callers' cache-save step failed every run. npmPublish.yml's three call sites (ctc-open, ctcCloseSuccess, ctcCloseFail) still forwarded the now-undeclared inputs, so GitHub Actions rejected the call outright and broke every release through npmPublish.yml (e.g. oclif/plugin-plugins). Co-Authored-By: Claude Sonnet 5 --- .github/workflows/npmPublish.yml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/.github/workflows/npmPublish.yml b/.github/workflows/npmPublish.yml index cb58cd8..e0fe36f 100644 --- a/.github/workflows/npmPublish.yml +++ b/.github/workflows/npmPublish.yml @@ -141,9 +141,6 @@ jobs: with: githubTag: ${{ inputs.githubTag }} nodeVersion: ${{ inputs.nodeVersion }} - package-manager: ${{ inputs.packageManager }} - package-manager-version: ${{ inputs.packageManagerVersion }} - cache-dependency-path: ${{ inputs.cacheDependencyPath || (inputs.packageManager == 'yarn' && 'yarn.lock' || (inputs.packageManager == 'pnpm' && 'pnpm-lock.yaml' || 'package-lock.json')) }} secrets: inherit npm-publish: @@ -246,9 +243,6 @@ jobs: with: changeCaseId: ${{needs.ctc-open.outputs.changeCaseId}} nodeVersion: ${{ inputs.nodeVersion }} - package-manager: ${{ inputs.packageManager }} - package-manager-version: ${{ inputs.packageManagerVersion }} - cache-dependency-path: ${{ inputs.cacheDependencyPath || (inputs.packageManager == 'yarn' && 'yarn.lock' || (inputs.packageManager == 'pnpm' && 'pnpm-lock.yaml' || 'package-lock.json')) }} ctcCloseFail: needs: [ctc-open, npm-publish] @@ -259,6 +253,3 @@ jobs: changeCaseId: ${{ needs.ctc-open.outputs.changeCaseId }} nodeVersion: ${{ inputs.nodeVersion }} status: Not Implemented - package-manager: ${{ inputs.packageManager }} - package-manager-version: ${{ inputs.packageManagerVersion }} - cache-dependency-path: ${{ inputs.cacheDependencyPath || (inputs.packageManager == 'yarn' && 'yarn.lock' || (inputs.packageManager == 'pnpm' && 'pnpm-lock.yaml' || 'package-lock.json')) }}