From 0cb9522441b4ac50529e40732719b5b31907fdbd Mon Sep 17 00:00:00 2001 From: Alexander Dahmen Date: Wed, 4 Nov 2026 12:35:35 +0100 Subject: [PATCH] feat(git): Add update command for ACLs Extend describe command to show ACLs. STACKITCLI-555 Signed-off-by: Alexander Dahmen --- docs/stackit_git_instance.md | 3 +- docs/stackit_git_instance_create.md | 2 +- docs/stackit_git_instance_describe.md | 11 +- docs/stackit_git_instance_update.md | 44 +++ internal/cmd/git/instance/create/create.go | 6 +- .../cmd/git/instance/create/create_test.go | 17 ++ internal/cmd/git/instance/delete/delete.go | 8 +- .../cmd/git/instance/describe/describe.go | 18 +- .../git/instance/describe/describe_test.go | 9 + internal/cmd/git/instance/instance.go | 2 + internal/cmd/git/instance/update/update.go | 156 ++++++++++ .../cmd/git/instance/update/update_test.go | 279 ++++++++++++++++++ 12 files changed, 539 insertions(+), 16 deletions(-) create mode 100644 docs/stackit_git_instance_update.md create mode 100644 internal/cmd/git/instance/update/update.go create mode 100644 internal/cmd/git/instance/update/update_test.go diff --git a/docs/stackit_git_instance.md b/docs/stackit_git_instance.md index 077695d87..22351004d 100644 --- a/docs/stackit_git_instance.md +++ b/docs/stackit_git_instance.md @@ -32,6 +32,7 @@ stackit git instance [flags] * [stackit git](./stackit_git.md) - Provides functionality for STACKIT Git * [stackit git instance create](./stackit_git_instance_create.md) - Creates STACKIT Git instance * [stackit git instance delete](./stackit_git_instance_delete.md) - Deletes STACKIT Git instance -* [stackit git instance describe](./stackit_git_instance_describe.md) - Describes STACKIT Git instance +* [stackit git instance describe](./stackit_git_instance_describe.md) - Shows details of a STACKIT Git instance * [stackit git instance list](./stackit_git_instance_list.md) - Lists all instances of STACKIT Git +* [stackit git instance update](./stackit_git_instance_update.md) - Updates STACKIT Git instance diff --git a/docs/stackit_git_instance_create.md b/docs/stackit_git_instance_create.md index c5d42ec3c..dccce29ed 100644 --- a/docs/stackit_git_instance_create.md +++ b/docs/stackit_git_instance_create.md @@ -26,7 +26,7 @@ stackit git instance create [flags] ### Options ``` - --acl strings Acl for the instance. + --acl strings List of IP networks in CIDR notation which are allowed to access this instance (default []) --flavor string Flavor of the instance. -h, --help Help for "stackit git instance create" --name string The name of the instance. diff --git a/docs/stackit_git_instance_describe.md b/docs/stackit_git_instance_describe.md index c355957ea..6c78a1d9c 100644 --- a/docs/stackit_git_instance_describe.md +++ b/docs/stackit_git_instance_describe.md @@ -1,10 +1,10 @@ ## stackit git instance describe -Describes STACKIT Git instance +Shows details of a STACKIT Git instance ### Synopsis -Describes a STACKIT Git instance by its internal ID. +Shows details of a STACKIT Git instance. ``` stackit git instance describe INSTANCE_ID [flags] @@ -13,8 +13,11 @@ stackit git instance describe INSTANCE_ID [flags] ### Examples ``` - Describe instance "xxx" - $ stackit git describe xxx + Get details of a STACKIT Git instance with ID "xxx" + $ stackit git instance describe xxx + + Get details of a STACKIT Git instance with ID "xxx" in JSON format + $ stackit git instance describe xxx --output-format json ``` ### Options diff --git a/docs/stackit_git_instance_update.md b/docs/stackit_git_instance_update.md new file mode 100644 index 000000000..aefcc916a --- /dev/null +++ b/docs/stackit_git_instance_update.md @@ -0,0 +1,44 @@ +## stackit git instance update + +Updates STACKIT Git instance + +### Synopsis + +Updates a STACKIT Git instance. + +``` +stackit git instance update INSTANCE_ID [flags] +``` + +### Examples + +``` + Update the ACL of the instance with ID "xxx" + $ stackit git instance update xxx --acl 1.2.3.0/24 + + Update the ACL of the instance with ID "xxx" with multiple ranges + $ stackit git instance update xxx --acl 1.2.3.0/24,4.5.6.0/24 +``` + +### Options + +``` + --acl strings List of IP networks in CIDR notation which are allowed to access this instance. Replaces the existing ACL. (default []) + -h, --help Help for "stackit git instance update" +``` + +### Options inherited from parent commands + +``` + -y, --assume-yes If set, skips all confirmation prompts + --async If set, runs the command asynchronously + -o, --output-format string Output format, (one of: [json, pretty, none, yaml]) + -p, --project-id string Project ID + --region string Target region for region-specific requests + --verbosity string Verbosity of the CLI, (one of: [debug, info, warning, error]) (default "info") +``` + +### SEE ALSO + +* [stackit git instance](./stackit_git_instance.md) - Provides functionality for STACKIT Git instances + diff --git a/internal/cmd/git/instance/create/create.go b/internal/cmd/git/instance/create/create.go index 6c4c046e4..76f050520 100644 --- a/internal/cmd/git/instance/create/create.go +++ b/internal/cmd/git/instance/create/create.go @@ -78,7 +78,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { result, err := request.Execute() if err != nil { - return fmt.Errorf("create stackit git instance: %w", err) + return fmt.Errorf("create STACKIT Git instance: %w", err) } // Wait for async operation, if async mode not enabled @@ -88,7 +88,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { return err }) if err != nil { - return fmt.Errorf("wait for stackit git Instance creation: %w", err) + return fmt.Errorf("wait for STACKIT Git instance creation: %w", err) } } @@ -103,7 +103,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { func configureFlags(cmd *cobra.Command) { cmd.Flags().String(nameFlag, "", "The name of the instance.") cmd.Flags().String(flavorFlag, "", "Flavor of the instance.") - cmd.Flags().StringSlice(aclFlag, []string{}, "Acl for the instance.") + cmd.Flags().Var(flags.CIDRSliceFlag(), aclFlag, "List of IP networks in CIDR notation which are allowed to access this instance") if err := flags.MarkFlagsRequired(cmd, nameFlag); err != nil { cobra.CheckErr(err) } diff --git a/internal/cmd/git/instance/create/create_test.go b/internal/cmd/git/instance/create/create_test.go index 212331500..93f3bcbdc 100644 --- a/internal/cmd/git/instance/create/create_test.go +++ b/internal/cmd/git/instance/create/create_test.go @@ -125,6 +125,23 @@ func TestParseInput(t *testing.T) { }), isValid: false, }, + { + description: "multiple acl entries", + flagValues: fixtureFlagValues(func(flagValues map[string]string) { + flagValues[aclFlag] = "1.2.3.0/24,4.5.6.0/24" + }), + isValid: true, + expectedModel: fixtureInputModel(func(model *inputModel) { + model.Acl = []string{"1.2.3.0/24", "4.5.6.0/24"} + }), + }, + { + description: "invalid acl", + flagValues: fixtureFlagValues(func(flagValues map[string]string) { + flagValues[aclFlag] = "invalid-cidr" + }), + isValid: false, + }, } for _, tt := range tests { diff --git a/internal/cmd/git/instance/delete/delete.go b/internal/cmd/git/instance/delete/delete.go index 2a59f4f55..7fcf1ff79 100644 --- a/internal/cmd/git/instance/delete/delete.go +++ b/internal/cmd/git/instance/delete/delete.go @@ -60,13 +60,13 @@ func NewCmd(params *types.CmdParams) *cobra.Command { instanceName, err := gitUtils.GetInstanceName(ctx, apiClient.DefaultAPI, model.ProjectId, model.InstanceId) if err != nil { - params.Printer.Debug(print.ErrorLevel, "get stackit git instance name: %v", err) + params.Printer.Debug(print.ErrorLevel, "get STACKIT Git instance name: %v", err) instanceName = model.InstanceId } else if instanceName == "" { instanceName = model.InstanceId } - prompt := fmt.Sprintf("Are you sure you want to delete the stackit git instance %q for %q?", instanceName, projectName) + prompt := fmt.Sprintf("Are you sure you want to delete the STACKIT Git instance %q for %q?", instanceName, projectName) err = params.Printer.PromptForConfirmation(prompt) if err != nil { return err @@ -87,7 +87,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { return err }) if err != nil { - return fmt.Errorf("wait for stackit git instance deletion: %w", err) + return fmt.Errorf("wait for STACKIT Git instance deletion: %w", err) } } @@ -95,7 +95,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command { if model.Async { operationState = "Triggered deletion of" } - params.Printer.Info("%s stackit git instance %s \n", operationState, model.InstanceId) + params.Printer.Info("%s STACKIT Git instance %s \n", operationState, model.InstanceId) return nil }, diff --git a/internal/cmd/git/instance/describe/describe.go b/internal/cmd/git/instance/describe/describe.go index 732148e91..47cd33587 100644 --- a/internal/cmd/git/instance/describe/describe.go +++ b/internal/cmd/git/instance/describe/describe.go @@ -3,6 +3,7 @@ package describe import ( "context" "fmt" + "strings" "github.com/stackitcloud/stackit-cli/internal/pkg/types" @@ -29,11 +30,16 @@ const instanceIdArg = "INSTANCE_ID" func NewCmd(params *types.CmdParams) *cobra.Command { cmd := &cobra.Command{ Use: fmt.Sprintf("describe %s", instanceIdArg), - Short: "Describes STACKIT Git instance", - Long: "Describes a STACKIT Git instance by its internal ID.", + Short: "Shows details of a STACKIT Git instance", + Long: "Shows details of a STACKIT Git instance.", Args: args.SingleArg(instanceIdArg, utils.ValidateUUID), Example: examples.Build( - examples.NewExample(`Describe instance "xxx"`, `$ stackit git describe xxx`), + examples.NewExample( + `Get details of a STACKIT Git instance with ID "xxx"`, + `$ stackit git instance describe xxx`), + examples.NewExample( + `Get details of a STACKIT Git instance with ID "xxx" in JSON format`, + `$ stackit git instance describe xxx --output-format json`), ), RunE: func(cmd *cobra.Command, args []string) error { ctx := context.Background() @@ -102,10 +108,16 @@ func outputResult(p *print.Printer, outputFormat string, resp *git.Instance) err table.AddSeparator() table.AddRow("VERSION", resp.Version) table.AddSeparator() + table.AddRow("FLAVOR", resp.Flavor) + table.AddSeparator() table.AddRow("STATE", resp.State) table.AddSeparator() table.AddRow("CREATED", resp.Created) table.AddSeparator() + if len(resp.Acl) > 0 { + table.AddRow("ACL", strings.Join(resp.Acl, ",")) + table.AddSeparator() + } if err := table.Display(p); err != nil { return fmt.Errorf("render table: %w", err) diff --git a/internal/cmd/git/instance/describe/describe_test.go b/internal/cmd/git/instance/describe/describe_test.go index f2589c578..e6b124c6a 100644 --- a/internal/cmd/git/instance/describe/describe_test.go +++ b/internal/cmd/git/instance/describe/describe_test.go @@ -210,6 +210,15 @@ func TestOutputResult(t *testing.T) { }, wantErr: false, }, + { + name: "with acl", + args: args{ + resp: &git.Instance{ + Acl: []string{"1.2.3.0/24", "4.5.6.0/24"}, + }, + }, + wantErr: false, + }, { name: "nil", args: args{}, diff --git a/internal/cmd/git/instance/instance.go b/internal/cmd/git/instance/instance.go index bd36a1cbd..8b74eaea7 100644 --- a/internal/cmd/git/instance/instance.go +++ b/internal/cmd/git/instance/instance.go @@ -5,6 +5,7 @@ import ( "github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/delete" "github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/describe" "github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/list" + "github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/update" "github.com/stackitcloud/stackit-cli/internal/pkg/args" "github.com/stackitcloud/stackit-cli/internal/pkg/types" "github.com/stackitcloud/stackit-cli/internal/pkg/utils" @@ -30,5 +31,6 @@ func addSubcommands(cmd *cobra.Command, params *types.CmdParams) { describe.NewCmd(params), create.NewCmd(params), delete.NewCmd(params), + update.NewCmd(params), ) } diff --git a/internal/cmd/git/instance/update/update.go b/internal/cmd/git/instance/update/update.go new file mode 100644 index 000000000..c6c49d3e9 --- /dev/null +++ b/internal/cmd/git/instance/update/update.go @@ -0,0 +1,156 @@ +package update + +import ( + "context" + "fmt" + + "github.com/stackitcloud/stackit-cli/internal/pkg/types" + + "github.com/spf13/cobra" + git "github.com/stackitcloud/stackit-sdk-go/services/git/v1betaapi" + "github.com/stackitcloud/stackit-sdk-go/services/git/v1betaapi/wait" + + "github.com/stackitcloud/stackit-cli/internal/pkg/args" + "github.com/stackitcloud/stackit-cli/internal/pkg/errors" + "github.com/stackitcloud/stackit-cli/internal/pkg/examples" + "github.com/stackitcloud/stackit-cli/internal/pkg/flags" + "github.com/stackitcloud/stackit-cli/internal/pkg/globalflags" + "github.com/stackitcloud/stackit-cli/internal/pkg/print" + "github.com/stackitcloud/stackit-cli/internal/pkg/services/git/client" + gitUtils "github.com/stackitcloud/stackit-cli/internal/pkg/services/git/utils" + "github.com/stackitcloud/stackit-cli/internal/pkg/spinner" + "github.com/stackitcloud/stackit-cli/internal/pkg/utils" +) + +const ( + instanceIdArg = "INSTANCE_ID" + + aclFlag = "acl" +) + +type inputModel struct { + *globalflags.GlobalFlagModel + InstanceId string + Acl []string +} + +func NewCmd(params *types.CmdParams) *cobra.Command { + cmd := &cobra.Command{ + Use: fmt.Sprintf("update %s", instanceIdArg), + Short: "Updates STACKIT Git instance", + Long: "Updates a STACKIT Git instance.", + Args: args.SingleArg(instanceIdArg, utils.ValidateUUID), + Example: examples.Build( + examples.NewExample( + `Update the ACL of the instance with ID "xxx"`, + `$ stackit git instance update xxx --acl 1.2.3.0/24`, + ), + examples.NewExample( + `Update the ACL of the instance with ID "xxx" with multiple ranges`, + `$ stackit git instance update xxx --acl 1.2.3.0/24,4.5.6.0/24`, + ), + ), + RunE: func(cmd *cobra.Command, args []string) error { + ctx := context.Background() + model, err := parseInput(params.Printer, cmd, args) + if err != nil { + return err + } + + // Configure API client + apiClient, err := client.ConfigureClient(params.Printer, params.CliVersion) + if err != nil { + return err + } + + instanceLabel, err := gitUtils.GetInstanceName(ctx, apiClient.DefaultAPI, model.ProjectId, model.InstanceId) + if err != nil { + params.Printer.Debug(print.ErrorLevel, "get instance name: %v", err) + instanceLabel = model.InstanceId + } else if instanceLabel == "" { + instanceLabel = model.InstanceId + } + + prompt := fmt.Sprintf("Are you sure you want to update instance %q?", instanceLabel) + err = params.Printer.PromptForConfirmation(prompt) + if err != nil { + return err + } + + // Call API + request := buildRequest(ctx, model, apiClient) + + resp, err := request.Execute() + if err != nil { + return fmt.Errorf("update STACKIT Git instance: %w", err) + } + + // Wait for async operation, if async mode not enabled + if !model.Async { + err := spinner.Run(params.Printer, "Updating STACKIT Git instance", func() error { + resp, err = wait.UpdateGitInstanceWaitHandler(ctx, apiClient.DefaultAPI, model.ProjectId, model.InstanceId).WaitWithContext(ctx) + return err + }) + if err != nil { + return fmt.Errorf("wait for STACKIT Git instance update: %w", err) + } + } + + return outputResult(params.Printer, model, instanceLabel, resp) + }, + } + + configureFlags(cmd) + return cmd +} + +func configureFlags(cmd *cobra.Command) { + cmd.Flags().Var(flags.CIDRSliceFlag(), aclFlag, "List of IP networks in CIDR notation which are allowed to access this instance. Replaces the existing ACL.") +} + +func parseInput(p *print.Printer, cmd *cobra.Command, cliArgs []string) (*inputModel, error) { + globalFlags := globalflags.Parse(p, cmd) + if globalFlags.ProjectId == "" { + return nil, &errors.ProjectIdError{} + } + + acl := flags.FlagToStringSliceValue(p, cmd, aclFlag) + + if acl == nil { + return nil, &errors.EmptyUpdateError{} + } + + model := inputModel{ + GlobalFlagModel: globalFlags, + InstanceId: cliArgs[0], + Acl: acl, + } + + p.DebugInputModel(model) + return &model, nil +} + +func buildRequest(ctx context.Context, model *inputModel, apiClient *git.APIClient) git.ApiPatchInstanceRequest { + return apiClient.DefaultAPI.PatchInstance(ctx, model.ProjectId, model.InstanceId).PatchInstancePayload(git.PatchInstancePayload{ + Acl: model.Acl, + }) +} + +func outputResult(p *print.Printer, model *inputModel, instanceLabel string, resp *git.Instance) error { + if model == nil { + return fmt.Errorf("input model is nil") + } + + return p.OutputResult(model.OutputFormat, resp, func() error { + if resp == nil { + return fmt.Errorf("API resp is nil") + } + + operationState := "Updated" + if model.Async { + operationState = "Triggered update of" + } + p.Outputf("%s instance %q\n", operationState, instanceLabel) + return nil + }) +} diff --git a/internal/cmd/git/instance/update/update_test.go b/internal/cmd/git/instance/update/update_test.go new file mode 100644 index 000000000..07f9b03d7 --- /dev/null +++ b/internal/cmd/git/instance/update/update_test.go @@ -0,0 +1,279 @@ +package update + +import ( + "context" + "testing" + + "github.com/google/go-cmp/cmp" + "github.com/google/go-cmp/cmp/cmpopts" + "github.com/google/uuid" + git "github.com/stackitcloud/stackit-sdk-go/services/git/v1betaapi" + + "github.com/stackitcloud/stackit-cli/internal/pkg/globalflags" + "github.com/stackitcloud/stackit-cli/internal/pkg/print" + "github.com/stackitcloud/stackit-cli/internal/pkg/testparams" + "github.com/stackitcloud/stackit-cli/internal/pkg/testutils" +) + +type testCtxKey struct{} + +var ( + testCtx = context.WithValue(context.Background(), testCtxKey{}, "foo") + testClient = &git.APIClient{DefaultAPI: &git.DefaultAPIService{}} + testProjectId = uuid.NewString() + testInstanceId = uuid.NewString() +) + +func fixtureArgValues(mods ...func(argValues []string)) []string { + argValues := []string{ + testInstanceId, + } + for _, mod := range mods { + mod(argValues) + } + return argValues +} + +func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]string { + flagValues := map[string]string{ + globalflags.ProjectIdFlag: testProjectId, + aclFlag: "0.0.0.0/0", + } + for _, mod := range mods { + mod(flagValues) + } + return flagValues +} + +func fixtureInputModel(mods ...func(model *inputModel)) *inputModel { + model := &inputModel{ + GlobalFlagModel: &globalflags.GlobalFlagModel{ProjectId: testProjectId, Verbosity: globalflags.VerbosityDefault}, + InstanceId: testInstanceId, + Acl: []string{"0.0.0.0/0"}, + } + for _, mod := range mods { + mod(model) + } + return model +} + +func fixtureRequest(mods ...func(request *git.ApiPatchInstanceRequest)) git.ApiPatchInstanceRequest { + request := testClient.DefaultAPI.PatchInstance(testCtx, testProjectId, testInstanceId) + request = request.PatchInstancePayload(git.PatchInstancePayload{ + Acl: []string{"0.0.0.0/0"}, + }) + for _, mod := range mods { + mod(&request) + } + return request +} + +func TestParseInput(t *testing.T) { + tests := []struct { + description string + argValues []string + flagValues map[string]string + isValid bool + expectedModel *inputModel + }{ + { + description: "base", + argValues: fixtureArgValues(), + flagValues: fixtureFlagValues(), + isValid: true, + expectedModel: fixtureInputModel(), + }, + { + description: "multiple acl entries", + argValues: fixtureArgValues(), + flagValues: fixtureFlagValues(func(flagValues map[string]string) { + flagValues[aclFlag] = "1.2.3.0/24,4.5.6.0/24" + }), + isValid: true, + expectedModel: fixtureInputModel(func(model *inputModel) { + model.Acl = []string{"1.2.3.0/24", "4.5.6.0/24"} + }), + }, + { + description: "invalid acl", + argValues: fixtureArgValues(), + flagValues: fixtureFlagValues(func(flagValues map[string]string) { + flagValues[aclFlag] = "invalid-cidr" + }), + isValid: false, + }, + { + description: "no values", + argValues: []string{}, + flagValues: map[string]string{}, + isValid: false, + }, + { + description: "no arg values", + argValues: []string{}, + flagValues: fixtureFlagValues(), + isValid: false, + }, + { + description: "no values to update", + argValues: fixtureArgValues(), + flagValues: fixtureFlagValues(func(flagValues map[string]string) { + delete(flagValues, aclFlag) + }), + isValid: false, + }, + { + description: "project id missing", + argValues: fixtureArgValues(), + flagValues: fixtureFlagValues(func(flagValues map[string]string) { + delete(flagValues, globalflags.ProjectIdFlag) + }), + isValid: false, + }, + { + description: "project id invalid 1", + argValues: fixtureArgValues(), + flagValues: fixtureFlagValues(func(flagValues map[string]string) { + flagValues[globalflags.ProjectIdFlag] = "" + }), + isValid: false, + }, + { + description: "project id invalid 2", + argValues: fixtureArgValues(), + flagValues: fixtureFlagValues(func(flagValues map[string]string) { + flagValues[globalflags.ProjectIdFlag] = "invalid-uuid" + }), + isValid: false, + }, + { + description: "instance id invalid 1", + argValues: []string{""}, + flagValues: fixtureFlagValues(), + isValid: false, + }, + { + description: "instance id invalid 2", + argValues: []string{"invalid-uuid"}, + flagValues: fixtureFlagValues(), + isValid: false, + }, + } + + for _, tt := range tests { + t.Run(tt.description, func(t *testing.T) { + testutils.TestParseInput(t, NewCmd, parseInput, tt.expectedModel, tt.argValues, tt.flagValues, tt.isValid) + }) + } +} + +func TestBuildRequest(t *testing.T) { + tests := []struct { + description string + model *inputModel + expectedRequest git.ApiPatchInstanceRequest + }{ + { + description: "base", + model: fixtureInputModel(), + expectedRequest: fixtureRequest(), + }, + { + description: "multiple acl entries", + model: fixtureInputModel(func(model *inputModel) { + model.Acl = []string{"1.2.3.0/24", "4.5.6.0/24"} + }), + expectedRequest: fixtureRequest(func(request *git.ApiPatchInstanceRequest) { + *request = request.PatchInstancePayload(git.PatchInstancePayload{ + Acl: []string{"1.2.3.0/24", "4.5.6.0/24"}, + }) + }), + }, + } + + for _, tt := range tests { + t.Run(tt.description, func(t *testing.T) { + request := buildRequest(testCtx, tt.model, testClient) + diff := cmp.Diff(request, tt.expectedRequest, + cmp.AllowUnexported(tt.expectedRequest, git.DefaultAPIService{}), + cmpopts.EquateComparable(testCtx), + ) + if diff != "" { + t.Fatalf("Data does not match: %s", diff) + } + }) + } +} + +func TestOutputResult(t *testing.T) { + type args struct { + model *inputModel + resp *git.Instance + } + tests := []struct { + name string + args args + wantErr bool + }{ + { + name: "nil", + args: args{}, + wantErr: true, + }, + { + name: "nil model", + args: args{ + resp: &git.Instance{}, + }, + wantErr: true, + }, + { + name: "nil resp", + args: args{ + model: fixtureInputModel(), + }, + wantErr: true, + }, + { + name: "empty", + args: args{ + model: fixtureInputModel(), + resp: &git.Instance{}, + }, + wantErr: false, + }, + { + name: "async", + args: args{ + model: fixtureInputModel(func(model *inputModel) { model.Async = true }), + resp: &git.Instance{}, + }, + wantErr: false, + }, + { + name: "json output", + args: args{ + model: fixtureInputModel(func(model *inputModel) { model.OutputFormat = print.JSONOutputFormat }), + resp: &git.Instance{}, + }, + wantErr: false, + }, + { + name: "yaml output", + args: args{ + model: fixtureInputModel(func(model *inputModel) { model.OutputFormat = print.YAMLOutputFormat }), + resp: &git.Instance{}, + }, + wantErr: false, + }, + } + params := testparams.NewTestParams() + + for _, tt := range tests { + t.Run(tt.name, func(t *testing.T) { + if err := outputResult(params.Printer, tt.args.model, "label", tt.args.resp); (err != nil) != tt.wantErr { + t.Errorf("outputResult() error = %v, wantErr %v", err, tt.wantErr) + } + }) + } +}