Repository navigation
Conversation
Rebuild src/onepassword/lib from the same 677fbba2 build artifacts, with each artifact downloaded into its own folder (linux-amd64 -> x86_64/, linux-arm64 -> aarch64/, darwin -> lib root, windows-x86_64 -> x86_64/), as the proposed publish-workflow fix does: - move the AArch64 libop_uniffi_core.so from the lib root to aarch64/ - add the x86-64 libop_uniffi_core.so to x86_64/ (it was overwritten) - move op_uniffi_core.dll from the lib root to x86_64/ - remove the stray op_uniffi_core.py at the lib root Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Test PR. Don't review or merge. It reproduces a broken native library layout in generated core-update branches, and checks that the proposed fix works. A separate PR will be opened for review and will link here.
What this tests
The core-update branches that the core publish workflow generates (for example
sdk-core/beta/2026-11-10-677fbba2, #247) have a brokensrc/onepassword/liblayout:x86_64/libop_uniffi_core.soaarch64/libop_uniffi_core.sox86_64/op_uniffi_core.dlllibop_uniffi_core.so(AArch64),op_uniffi_core.dll,op_uniffi_core.pycore.pyloads the native library from its own arch folder, so imports fail on Linux and Windows. macOS keeps its layout and works.Cause: the publish workflow downloads the four native-library artifacts (linux-amd64, linux-arm64, darwin, windows-x86_64) into one folder. The Linux and Windows artifacts don't keep their arch folder, so their files land at the root, and the arm64
.sooverwrites the amd64 one.Steps
3347189): the generated core update, unchanged. CI should fail intest-trustedwithOSError: .../lib/x86_64/libop_uniffi_core.so: cannot open shared object file.src/onepassword/librebuilt from the same build artifacts, but with each artifact downloaded into its own arch folder, as the proposed publish-workflow fix does. CI should pass on all OSes.Results
3347189test-trusted (ubuntu-latest, 3.13):OSError: .../lib/x86_64/libop_uniffi_core.so: cannot open shared object file(5 failed, 1 passed). Fail-fast cancelled the other 11 jobs.385e3d3test-trustedjobs pass (ubuntu, windows and macos × Python 3.10–3.13), for example 6 passed on ubuntu and macos 3.13. Lint and signed-commit checks pass.Commit 2 only moves files and adds the missing x86-64
.so. The.dylibfiles and bindings are byte-identical to commit 1, and file modes stay644, as the publish workflow writes them:libop_uniffi_core.so(AArch64): lib root →aarch64/op_uniffi_core.dll: lib root →x86_64/x86_64/libop_uniffi_core.so(x86-64): added from the linux-amd64 artifactop_uniffi_core.pyat the lib root: removedConclusion: downloading each native-library artifact into its own arch folder fixes the generated branch. The fix belongs in the core publish workflow, and the PR for that will link here.
🤖 Generated with Claude Code