[vkucera]

Fixes C-style, redundant, wrong, and dangerous casts (found by Clang-Tidy and cpplint).

• Remove redundant casts. (readability-redundant-casting)
• Remove const_cast. (cppcoreguidelines-pro-type-const-cast)
• Replace C-style casts with static_cast. (google-readability-casting, cpplint: readability/casting)
• Replace unsafe C-style casts with dynamic_cast. (cppcoreguidelines-pro-type-cstyle-cast)
• Replace static_cast in downcasts with dynamic_cast. (cppcoreguidelines-pro-type-static-cast-downcast)
• Replace reinterpret_cast with static_cast or dynamic_cast. (cppcoreguidelines-pro-type-reinterpret-cast)
• Replace two-step casting through void* with reinterpret_cast. (bugprone-casting-through-void)

[github-actions]

O2 linter results: ❌ 0 errors, ⚠️ 4991 warnings, 🔕 0 disabled

[vkucera]

Dear code owners, the PR is ready for review.
Please note that PWGEM/Dilepton/Utils/MomentumSmearer.h contains invalid casts from TH1D to TH1F which are marked with FIXME comments.

[mhemmer-cern]

@vkucera is this ready for review again with the latest commit?

[vkucera]

@vkucera is this ready for review again with the latest commit?

Hi @mhemmer-cern , now it should be OK.

[mhemmer-cern]

PM side is fine

[alibuild]

Error while checking build/O2Physics/code-check for d9c35ef at 2026-11-07 23:47:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 6 errors and 1045 warnings.'
Found 6 errors and 1045 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/19788abafddb16f934c8f276dc13aacdb961084a/O2Physics-code-check/errors.txt
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectron.cxx:303:24: error: variable length arrays in C++ are a Clang extension [clang-diagnostic-vla-cxx-extension,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectron.cxx:1245:24: error: variable length arrays in C++ are a Clang extension [clang-diagnostic-vla-cxx-extension,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMFTTrack.cxx:27:1: error: included header MagFieldParam.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/matchingMFT.cxx:216:24: error: variable length arrays in C++ are a Clang extension [clang-diagnostic-vla-cxx-extension,-warnings-as-errors]
PWGEM/Dilepton/Utils/ElectronModule.h:390:24: error: variable length arrays in C++ are a Clang extension [clang-diagnostic-vla-cxx-extension,-warnings-as-errors]
PWGEM/Dilepton/Utils/ElectronModule.h:415:24: error: variable length arrays in C++ are a Clang extension [clang-diagnostic-vla-cxx-extension,-warnings-as-errors]
++ [[ 1045 -gt 0 ]]
++ cat /sw/BUILD/19788abafddb16f934c8f276dc13aacdb961084a/O2Physics-code-check/warnings.txt
PWGEM/Dilepton/Core/DielectronCut.h:485:8: warning: function 'DielectronCut::SetMindEtadPhi' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:78:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:101:8: warning: constructor does not initialize these fields: ccdb, mRunNumber, d_bz [cppcoreguidelines-pro-type-member-init]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:326:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:354:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:355:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:371:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:372:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:388:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:389:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:406:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:407:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:463:39: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:464:43: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:465:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:501:15: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:510:22: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:728:9: warning: if with identical then and else branches [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:758:105: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:857:9: warning: if with identical then and else branches [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:891:105: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:1035:13: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:1041:13: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:1137:24: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:1164:39: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:1364:7: warning: if with identical then and else branches [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:1393:105: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonHadronMPC.h:1414:13: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
[0 more errors; see full log]

Full log here.

[vkucera]

Dear @amaringarcia @dsekihat @feisenhu @hscheid @jokonig @mhemmer-cern @mikesas @rbailhac @reygers, can you please review the PR?

[vkucera]

Dear @dsekihat @feisenhu, can you please review the PR?

[vkucera]

Dear @dsekihat @feisenhu, it's been a week. Can you please review the PR?

[rbailhac]

Hi @vkucera ,

nice to read "Dear code owners, the PR is ready for review.
Please note that PWGEM/Dilepton/Utils/MomentumSmearer.h contains invalid casts from TH1D to TH1F which are marked with FIXME comments."

This commit is breaking our analysis on hyperloop. One example is here:
https://alimonitor.cern.ch/train-workdir/tests/0080/00803921/stdout.log

Do you have any suggestions how to fix it ?

Thanks,
Raphaelle

[vkucera]

Hi @vkucera ,

nice to read "Dear code owners, the PR is ready for review. Please note that PWGEM/Dilepton/Utils/MomentumSmearer.h contains invalid casts from TH1D to TH1F which are marked with FIXME comments."

This commit is breaking our analysis on hyperloop. One example is here: https://alimonitor.cern.ch/train-workdir/tests/0080/00803921/stdout.log

Do you have any suggestions how to fix it ?

Thanks, Raphaelle

Hi @rbailhac , the commit is not breaking your analysis. Your analysis was already broken before. This commit just makes the problem appear. The solution depends on what type of histogram you need in fVecReso. You can change it to std::vector<TH1D*> or std::vector<TH1*> or implement a valid conversion from TH1D to TH1F.