Repository navigation
[Common,DPG] TPC PID workflows: provide reproducibility of randomization - #18634
Merged
Merged
Conversation
lubynets
requested review from
a team,
alcaliva,
alibuild,
catalinristea,
chiarazampolli,
ddobrigk,
dsekihat,
iarsene,
jgrosseo and
ktf
as code owners
November 6, 2026 22:28
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
lubynets
changed the title
dsekihat
approved these changes
Nov 9, 2026
alcaliva
approved these changes
Nov 10, 2026
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeds random engines of several TPC PID related workflows with the timestamp of the zeroth bunch crossing. It provides, from one point of view, the reproducibility of results (which is missing with seed == 0, see ROOT documentation, link), and from another point of view, ensures that we don't get odd correlations across all dataframes, if the seed is always the same.
Tagging @amaringarcia