Repository navigation
[PWGLF] Fix unused variables, parameters, values - #18645
Merged
Merged
Conversation
Fixes errors from the following Clang-Tidy categories: - `clang-analyzer-deadcode.DeadStores` - `clang-diagnostic-unused-parameter` - `clang-diagnostic-unused-variable` Most errors are fixed temporarily by commenting out the unused bits and by adding a `FIXME: unused` comment. The final fix is to either remove the unused bits or to fix the bugs which has to be done by someone who knows the intended behaviour.
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
vkucera
marked this pull request as ready for review
November 7, 2026 18:08
vkucera
requested review from
HorstMa,
alibuild,
ercolessi,
lhusova,
maciacco,
mario-krueger,
mpuccio,
omvazque,
romainschotter and
skundu692
as code owners
November 7, 2026 18:08
Collaborator
Collaborator
|
Error while checking build/O2Physics/code-check for 47ce03f at 2026-11-07 19:32: Full log here. |
Collaborator
maciacco
approved these changes
Nov 8, 2026
romainschotter
approved these changes
Nov 8, 2026
romainschotter
enabled auto-merge (squash)
November 8, 2026 12:32
vkucera
disabled auto-merge
November 10, 2026 12:53
vkucera
enabled auto-merge (squash)
November 10, 2026 12:53
Collaborator
Author
|
Dear @skundu692 @mpuccio @omvazque, can you please review the PR? |
mpuccio
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes errors from the following Clang-Tidy categories:
clang-analyzer-deadcode.DeadStoresclang-diagnostic-unused-parameterclang-diagnostic-unused-variableMost errors are fixed temporarily by commenting out the unused bits and by adding a
FIXME: unusedcomment.The final fix is to either remove the unused bits or to fix the bugs which has to be done by someone who knows the intended behaviour.