Skip to content

[PWGCF] Long range correlation update on MFT and added purity correction - #18648

Merged
dsarkaralice merged 5 commits into
AliceO2Group:masterfrom
S10GPhysics:longrangeupdate
Nov 9, 2026
Merged

dsarkaralice merged 5 commits into
AliceO2Group:masterfrom
S10GPhysics:longrangeupdate

Conversation

@S10GPhysics

Copy link
Copy Markdown
Contributor

No description provided.

Removed MFT track selection configurations and related processing code.
Removed unused SOA table declarations and includes to clean up the header file.
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 7 warnings, 🔕 3 disabled

@alibuild

alibuild commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for f9a11b3 at 2026-11-07 19:38:

## sw/BUILD/O2-latest/log
CMake Error at dependencies/FindFairRoot.cmake:68 (set_target_properties):
CMake Error at /sw/slc9_x86-64/CMake/v4.1.4-6/share/cmake-4.1/Modules/FeatureSummary.cmake:499 (message):

Full log here.

@alibuild

alibuild commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for f9a11b3 at 2026-11-08 01:26:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 7 errors and 109 warnings.'
Found 7 errors and 109 warnings.
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/46f6a1db321bb62af8351a091d783e425ac9e1e0/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:55:1: error: included header Utils.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:62:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:64:1: error: included header bitset is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:81:23: error: unused variable 'CintZero' [clang-diagnostic-unused-const-variable,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:336:17: error: C-style casts are discouraged; use constructor call syntax [google-readability-casting,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:27:1: error: included header Centrality.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/longrangecorrDerived.cxx:30:1: error: included header Multiplicity.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 109 -gt 0 ]]
++ cat /sw/BUILD/46f6a1db321bb62af8351a091d783e425ac9e1e0/O2Physics-code-check/warnings.txt
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:95:10: warning: variable 'axisEvent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:96:10: warning: variable 'axisTrackSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:104:8: warning: constructor does not initialize these fields: ccdb, pdg [cppcoreguidelines-pro-type-member-init]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:249:30: warning: initializer for member 'cfgSgCuts' is redundant [readability-redundant-member-init]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:323:41: warning: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:325:38: warning: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:367:35: warning: initializer for member 'ft0gainvalues' is redundant [readability-redundant-member-init]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:407:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:409:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:587:11: warning: implicit conversion 'float' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:587:11: warning: narrowing conversion from 'float' to 'bool' [bugprone-narrowing-conversions]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:588:92: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:606:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:608:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:735:186: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:774:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:776:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:778:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:781:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:884:142: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:887:104: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:889:104: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:901:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:903:154: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:905:102: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:907:102: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:917:140: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for f9a11b3 at 2026-11-07 19:39:

## sw/BUILD/O2-latest/log
CMake Error at dependencies/FindFairRoot.cmake:68 (set_target_properties):
CMake Error at /sw/slc9_x86-64/CMake/v4.1.4-6/share/cmake-4.1/Modules/FeatureSummary.cmake:499 (message):

Full log here.

@dsarkaralice
dsarkaralice enabled auto-merge (squash) November 9, 2026 13:37
@dsarkaralice
dsarkaralice merged commit 8df01f1 into AliceO2Group:master Nov 9, 2026
14 of 15 checks passed
DelloStritto pushed a commit to DelloStritto/O2Physics that referenced this pull request Nov 9, 2026
@S10GPhysics
S10GPhysics deleted the longrangeupdate branch November 11, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants