[PWGJE] Add ITS PID veto and pO rapidity QA to nuclei-in-jets analysis by arvindkhuntia · Pull Request #18649 · AliceO2Group/O2Physics

arvindkhuntia · 2026-11-07T20:45:02Z

No description provided.

github-actions · 2026-11-07T20:45:18Z

O2 linter results: ❌ 0 errors, ⚠️ 54 warnings, 🔕 0 disabled

alibuild · 2026-11-07T23:39:02Z

Error while checking build/O2Physics/code-check for efe872c at 2026-11-08 00:39:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 3 errors and 213 warnings.'
Found 3 errors and 213 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/d35b4e4d9188ef2adf4bd15b2a13ce79490d676d/O2Physics-code-check/errors.txt
PWGJE/Tasks/nucleiInJets.cxx:94:12: error: no header providing "PDG_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/nucleiInJets.cxx:371:54: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGJE/Tasks/nucleiInJets.cxx:2126:66: error: no header providing "o2::track::PID" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 213 -gt 0 ]]
++ cat /sw/BUILD/d35b4e4d9188ef2adf4bd15b2a13ce79490d676d/O2Physics-code-check/warnings.txt
PWGJE/Tasks/nucleiInJets.cxx:64:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGJE/Tasks/nucleiInJets.cxx:70:8: warning: constructor does not initialize these fields: ccdb, pdgDB [cppcoreguidelines-pro-type-member-init]
PWGJE/Tasks/nucleiInJets.cxx:306:9: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGJE/Tasks/nucleiInJets.cxx:981:12: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGJE/Tasks/nucleiInJets.cxx:988:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:991:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:995:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:998:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1000:53: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1002:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1004:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1006:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1008:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1010:54: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1018:45: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1020:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1022:82: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1032:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1033:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Tasks/nucleiInJets.cxx:1034:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Tasks/nucleiInJets.cxx:1034:9: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1054:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1056:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1064:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1066:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1072:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1074:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1089:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1098:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1152:35: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/nucleiInJets.cxx:1157:35: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

nzardosh · 2026-11-09T10:23:16Z

+      if (itsPid.applyItsPidInc) {
+        jetHist.fill(HIST("tracksInc/qa/h2ITSNsigmaProtonVsPt"), trk.pt(), nSigmaITSPr);
+        jetHist.fill(HIST("tracksInc/qa/h2ITSNsigmaDeuteronVsPt"), trk.pt(), nSigmaITSDe);
+        jetHist.fill(HIST("tracksInc/qa/h2ITSNsigmaHeliumVsPt"), 2.0 * trk.pt(), nSigmaITSHe);


is it intended here to multiply by 2 instead of diving the pT by 2?

Hi @nzardosh,

Thank you for the comment. Yes, the multiplication is intentional, as the stored track pT is rigidity, so for helium (|Z|=2) we multiply by 2 to obtain the physical pT.

nzardosh · 2026-11-09T10:24:33Z

+      }
+      const bool passItsPidPr = !itsPid.applyItsPidInc || track.pt() >= itsPid.ptMaxItsPidProt || (nSigmaITSPr >= itsPid.nSigmaItsMin && nSigmaITSPr <= itsPid.nSigmaItsMax);
+      const bool passItsPidDe = !itsPid.applyItsPidInc || track.pt() >= itsPid.ptMaxItsPidDeut || (nSigmaITSDe >= itsPid.nSigmaItsMin && nSigmaITSDe <= itsPid.nSigmaItsMax);
+      const bool passItsPidHe = !itsPid.applyItsPidInc || 2.0 * track.pt() >= itsPid.ptMaxItsPidHel || (nSigmaITSHe >= itsPid.nSigmaItsMin && nSigmaITSHe <= itsPid.nSigmaItsMax);


also here and a few lines below should these by multiplications by 2 or divisions?

Yes, the multiplication is intentional, as the stored track pT is rigidity, so for helium (|Z|=2) we multiply by 2 to obtain the physical pT.

AliceO2Group#18649) Co-authored-by: Arvind Khuntia <arvind.khuntia@cern.ch>

Arvindiiti and others added 5 commits November 6, 2026 20:01

[PWGJE] Fix leading-jet selection (Rec) and event normalization

0ede89c

Use corrected jet pT for leading-jet selection

e789ea5

[PWGJE] Use int32_t for jet-ID

a3813ca

[PWGJE] Add ITS PID veto and pO rapidity QA to nuclei-in-jets analysis

bb41d1a

Merge branch 'AliceO2Group:master' into master

efe872c

arvindkhuntia requested review from alibuild, fjonasALICE, jaimenorman, mhemmer-cern and nzardosh as code owners November 7, 2026 20:45

github-actions Bot added the pwgje label Nov 7, 2026

code check error solved

ab531bf

alibuild mentioned this pull request Nov 8, 2026

Please consider the following formatting changes to #18649 arvindkhuntia/O2Physics#1

Closed

clang-format

9ef9719

nzardosh reviewed Nov 9, 2026

View reviewed changes

nzardosh approved these changes Nov 9, 2026

View reviewed changes

nzardosh merged commit d5c58b1 into AliceO2Group:master Nov 9, 2026
17 checks passed

DelloStritto pushed a commit to DelloStritto/O2Physics that referenced this pull request Nov 9, 2026

[PWGJE] Add ITS PID veto and pO rapidity QA to nuclei-in-jets analysis (

035bbce

AliceO2Group#18649) Co-authored-by: Arvind Khuntia <arvind.khuntia@cern.ch>

Navigation Menu

Repository navigation

[PWGJE] Add ITS PID veto and pO rapidity QA to nuclei-in-jets analysis - #18649

[PWGJE] Add ITS PID veto and pO rapidity QA to nuclei-in-jets analysis#18649
nzardosh merged 7 commits into
AliceO2Group:masterfrom
arvindkhuntia:master

arvindkhuntia commented Nov 7, 2026

Uh oh!

github-actions Bot commented Nov 7, 2026

Uh oh!

alibuild commented Nov 7, 2026

Uh oh!

nzardosh Nov 9, 2026

Uh oh!

arvindkhuntia Nov 9, 2026

Uh oh!

nzardosh Nov 9, 2026

Uh oh!

arvindkhuntia Nov 9, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Conversation

arvindkhuntia commented Nov 7, 2026

Uh oh!

github-actions Bot commented Nov 7, 2026

Uh oh!

alibuild commented Nov 7, 2026

Uh oh!

nzardosh Nov 9, 2026

Choose a reason for hiding this comment

Uh oh!

arvindkhuntia Nov 9, 2026

Choose a reason for hiding this comment

Uh oh!

nzardosh Nov 9, 2026

Choose a reason for hiding this comment

Uh oh!

arvindkhuntia Nov 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

4 participants