Repository navigation
Conversation
|
O2 linter results: ❌ 0 errors, |
Please consider the following formatting changes to AliceO2Group#18729
larsfop
marked this pull request as ready for review
November 13, 2026 12:07
larsfop
requested review from
XiaozhiBai,
alibuild,
axti98,
glegras,
iarsene,
lucamicheletti93,
mguilbau and
shreyasiacharya
as code owners
November 13, 2026 12:07
iarsene
reviewed
Nov 13, 2026
Comment on lines
+4635
to
+4646
| if constexpr (TCandidateType == VarManager::kDsToKKPi) { | ||
| trackSelection = (assoc.isBarrelSelected_raw() & fTrackCutBitMap); | ||
| if (trackSelection == 0) { | ||
| continue; | ||
| } | ||
| auto track = assoc.template reducedtrack_as<TTracks>(); | ||
| if (track.globalIndex() == dilepton.index0Id() || track.globalIndex() == dilepton.index1Id()) { | ||
| continue; | ||
| } | ||
| VarManager::FillDileptonHadron(dilepton, track, fValuesHadron); | ||
| VarManager::FillDileptonTrackVertexing<TCandidateType, TEventFillMap, TTrackFillMap>(event, lepton1, lepton2, track, fValuesHadron); | ||
| } |
Collaborator
There was a problem hiding this comment.
You don't need to add this code, you can just add this case together with the kBtoJpsiEEK. In that same place, I suggest to add an if() statement so that the VarManager::FillEnergyCorrelatorTriple() is called only when the fConfigEnergycorrelator configurable is true. I also suggest to add a new configurable to switch on/off the writing of the "BmesonsTable".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.