Repository navigation
[OGUI-1949] Add basic API auth routes - #3714
Open
isaachilly wants to merge 5 commits into
Open
isaachilly wants to merge 5 commits into
isaachilly wants to merge 5 commits into
Conversation
isaachilly
changed the base branch from
dev
to
feature/ILG/OGUI-1939/vite-dev-server
November 9, 2026 16:33
isaachilly
force-pushed
the
feature/FRM/OGUI-1949/Add-api-auth-routes
branch
from
November 9, 2026 16:34
28a4b7d to
6953c5d
Compare
isaachilly
force-pushed
the
feature/FRM/OGUI-1949/Add-api-auth-routes
branch
from
November 10, 2026 15:45
f627e3f to
7e3552a
Compare
Add optional api auth routes, plus a frontend session redirect to start login when no token is present. Add tests to cover the new auth flows.
When the /api/login path is not registered the router falls back to /api, /api requires auth in its middleware and thus we get 403 not 404.
Redirect read result from evaluate that triggers the navigation. Catch this error and also store the result in session storage.
isaachilly
force-pushed
the
feature/FRM/OGUI-1949/Add-api-auth-routes
branch
from
November 11, 2026 18:58
a2b7696 to
82a998a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+203
to
+206
| this.app.get('/api/login', (req, res) => { | ||
| delete req.query.token; | ||
| return this.openid ? this.ident(req, res) : this.addDefaultUserData(req, res); | ||
| }); |
isaachilly
marked this pull request as ready for review
November 11, 2026 19:33
isaachilly
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
Ticket:
Code:
Add the
apiAuthRoutesHTTP option (defaultfalse). When on, auth routes are registered under/api./api/loginalways starts a fresh login./api/callbackis new callback handled.Adapt sessionService to accept a loginUrl, when there is no token, it redirects to it.
Reviewer: