Repository navigation
Revert "Antalya 26.8 Backport of #126138 - Revert "Revert "Verify the server certificate hostname on outbound TLS connections""" - #2842
Conversation
…Verify the server certificate hostname on outbound TLS connections"""
CI triage for 10e50a4There are 3 failing checks, and none of them come from this PR. 2 are pre-existing on The PR head is base
1.
|
CI triage for
|
| Check | Failing test | Class | Caused by this PR? |
|---|---|---|---|
Regression release swarms |
/swarms/feature/node failure/cpu overload (+ … all swarm nodes) |
already failing | No. Same failures on #2913 |
Regression release s3_azure_1 |
/s3/azure/part 1/disk/remote host filter, …/disk/syntax |
already failing | No. Same failures on #2913 |
Regression release cas_lightweight_delete_4 |
/lightweight delete/concurrent delete/AggregatingMergeTree/concurrent delete without overlap |
already failing | No. Same failure on #2913 |
| Stateless (amd_binary, cas s3 storage, parallel) | 03770_min_columns_to_activate_adaptive_write_buffer |
probably flaky (memory headroom) | No. Different code path |
1. RegressionTestsRelease / Swarms: already failing
✘ [ Fail ] '/swarms/feature/node failure/cpu overload' (5m 3s)
✘ [ Fail ] '/swarms/feature/node failure/cpu overload all swarm nodes' (5m 7s)
Code: 209. DB::Exception: ... Timeout exceeded while reading from socket (socket (172.19.0.6:9000), receive timeout 300000 ms): While executing Remote. (SOCKET_TIMEOUT)
#2913 fails the same two scenarios with the same SOCKET_TIMEOUT on plain TCP port 9000 (job 135267307883). No TLS is involved. Next step: none for this PR. This is a stress-scenario timeout that should be tracked on the base branch.
2. RegressionTestsRelease / S3 (azure, 1): already failing
✘ [ Fail ] '/s3/azure/part 1/disk/remote host filter' (16m 54s)
ClickHouse server is not healthy
<Error> Application: Code: 491. DB::Exception: URL "http://azurite:10000" is not allowed in configuration file, see <remote_url_allow_hosts>. (UNACCEPTABLE_URL)
✘ [ Fail ] '/s3/azure/part 1/disk/syntax' (5m 15s)
#2913 fails the same two scenarios with the same UNACCEPTABLE_URL startup error (job 135267315238). The server can't start because http://azurite:10000 isn't in remote_url_allow_hosts. syntax then fails because the server is still down. This looks related to #2905 (Do not check Azure disks from the server config against remote_url_allow_hosts), but that's my guess and I didn't verify it. The server log also has a tlsv1 alert unknown ca line. That is a CA rejection on the server's 9440 port, not a hostname check, and it isn't the failing assertion. Next step: none for this PR. Expect this to clear once #2905 (or a matching test update) lands.
3. RegressionTestsRelease / CASLightweightDelete (4): already failing
✘ [ Fail ] '/lightweight delete/concurrent delete/AggregatingMergeTree/concurrent delete without overlap' (36s 451ms)
AssertionError
#2913 fails the same scenario (job 135267314553). Next step: none for this PR.
4. Stateless tests (amd_binary, cas s3 storage, parallel): 1 of 13,781 failed, probably flaky
FAIL 03770_min_columns_to_activate_adaptive_write_buffer
Code: 241. DB::Exception: Query memory limit exceeded: would use 50.78 MiB (attempt to allocate chunk of 2.00 MiB), maximum: 50.00 MiB. (MEMORY_LIMIT_EXCEEDED)
(in query: insert into metric_log_1 select * from generateRandom() limit 1 settings max_memory_usage = '50Mi' ...)
11. src/IO/WriteBufferFromS3.cpp:115 WriteBufferFromS3::WriteBufferFromS3
14. .../ContentAddressed/Backend/CasObjectStorageBackend.cpp:923 Cas::ObjectStorageBackend::publish
19. .../ContentAddressed/ContentAddressedTransaction.cpp:1869 Cas::fanOutBlobUploads
The limit was exceeded by 0.78 MiB while allocating a 2 MiB S3 write buffer. That allocation happens inside the CAS parallel blob-upload fan-out (randomized --max_insert_threads 3). Nothing in that path goes through Poco SSL hostname checks, and this PR changes nothing else. I could not confirm it fails on base: the latest base MasterCI (0aa837e) and #2913 attempt 1 both passed this suite. So I'm calling it a narrow memory margin: the fixed 50 MiB budget plus several concurrent CAS upload buffers. That makes it a CAS-side flake, not something from this revert. Next step: safe to re-run. If it fails again, the fix belongs in the test or the CAS branch, not here: raise the test's max_memory_usage for CAS storage, or tag it to skip on CAS. I'll file that separately if you'd like.
Nothing in this PR needs fixing based on this CI run. The failures above don't block the revert, except that the CAS stateless job needs a re-run. If you want more confidence, the remaining step is to wait for SQLLogic/SQLStorm to finish.
Reverts #2671 due to issues in CI
Changelog category (leave one):
CI/CD Options
Exclude tests:
Regression jobs to run: