Skip to content

Antalya-26.8 - Drop CAS log configs on installed-binary integration nodes - #2890

Merged
mkmkme merged 2 commits into
antalya-26.8from
fix/antalya-26.8/cas-log-compat-images
Nov 17, 2026
Merged

mkmkme merged 2 commits into
antalya-26.8from
fix/antalya-26.8/cas-log-compat-images

Conversation

@mkmkme

@mkmkme mkmkme commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Integration instances with with_installed_binary run the binary of their image but get the main config of this checkout, which has the Antalya-only cas_log and cas_gc_log sections. Recent upstream binaries reject them with UNKNOWN_ELEMENT_IN_CONFIG, the server exits, and the test times out waiting for the instance. This breaks test_backward_compatibility/test_custom_s3_disk_remote_url_allow_hosts.py on antalya-26.8, and test_create_union_system_log_tables in the 26.8.37 bump.

The harness now removes both sections from such instances by default. An instance whose image knows them, like the Antalya node of test_cas_ref_move_compat, keeps them with installed_binary_supports_cas_logs=True.

Related: #2870 (comment)

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

...

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • Aarch64 tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • CAS (content-addressed storage; Antalya only)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • OAuth (5m)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

Integration instances with `with_installed_binary` run the binary of
their image, but get the main config of this checkout. It has the
Antalya-only `cas_log` and `cas_gc_log` sections, so a recent upstream
binary refuses to start with `UNKNOWN_ELEMENT_IN_CONFIG`, and the test
times out waiting for the instance. This breaks
`test_custom_s3_disk_remote_url_allow_hosts` on `antalya-26.8` and
`test_create_union_system_log_tables` in the 26.8.37 bump.

Remove both sections from such instances by default. An instance whose
image knows them, like the Antalya node of `test_cas_ref_move_compat`,
keeps them with `installed_binary_supports_cas_logs=True`.

Related: #2870 (comment)
@mkmkme mkmkme added antalya cicd Improvements and fixes to the CICD process CAS antalya-26.8 labels Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Workflow [PR], commit [09ec4d2]

k-morozov
k-morozov previously approved these changes Nov 17, 2026
Nothing checked that `installed_binary_supports_cas_logs=True` keeps the
`cas_log` section on the Antalya node of `test_cas_ref_move_compat`: the
test reads `system.cas_log` only on the new node, so it would still pass
if the harness removed the section. Count the old node's CAS log rows
after its first insert.
@mkmkme mkmkme added the port-antalya PRs to be ported to all new Antalya releases label Nov 17, 2026
@mkmkme
mkmkme merged commit 2b84369 into antalya-26.8 Nov 17, 2026
196 of 199 checks passed
@mkmkme mkmkme added the verified Approved for release label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

antalya antalya-26.8 CAS cicd Improvements and fixes to the CICD process port-antalya PRs to be ported to all new Antalya releases verified Approved for release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants