Repository navigation
Antalya-26.8 - Drop CAS log configs on installed-binary integration nodes - #2890
Merged
Merged
Conversation
Integration instances with `with_installed_binary` run the binary of their image, but get the main config of this checkout. It has the Antalya-only `cas_log` and `cas_gc_log` sections, so a recent upstream binary refuses to start with `UNKNOWN_ELEMENT_IN_CONFIG`, and the test times out waiting for the instance. This breaks `test_custom_s3_disk_remote_url_allow_hosts` on `antalya-26.8` and `test_create_union_system_log_tables` in the 26.8.37 bump. Remove both sections from such instances by default. An instance whose image knows them, like the Antalya node of `test_cas_ref_move_compat`, keeps them with `installed_binary_supports_cas_logs=True`. Related: #2870 (comment)
k-morozov
previously approved these changes
Nov 17, 2026
Nothing checked that `installed_binary_supports_cas_logs=True` keeps the `cas_log` section on the Antalya node of `test_cas_ref_move_compat`: the test reads `system.cas_log` only on the new node, so it would still pass if the harness removed the section. Count the old node's CAS log rows after its first insert.
k-morozov
approved these changes
Nov 17, 2026
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration instances with
with_installed_binaryrun the binary of their image but get the main config of this checkout, which has the Antalya-onlycas_logandcas_gc_logsections. Recent upstream binaries reject them withUNKNOWN_ELEMENT_IN_CONFIG, the server exits, and the test times out waiting for the instance. This breakstest_backward_compatibility/test_custom_s3_disk_remote_url_allow_hosts.pyonantalya-26.8, andtest_create_union_system_log_tablesin the 26.8.37 bump.The harness now removes both sections from such instances by default. An instance whose image knows them, like the Antalya node of
test_cas_ref_move_compat, keeps them withinstalled_binary_supports_cas_logs=True.Related: #2870 (comment)
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: