Repository navigation
fix: Convert Parquet NANOS footer stats to microseconds in manifest bounds - #228
Merged
subkanthi merged 1 commit intoNov 19, 2026
Merged
Conversation
…ounds `ice insert --no-copy` and `--force-no-copy` copy Parquet footer min/max into Iceberg manifest bounds. For a `timestamp`/`timestamptz` column the bounds must be microseconds, but NANOS statistics were copied unchanged, so a nanosecond file produced bounds about 1000x too large. Divide NANOS statistics by 1000. A remainder widens the lower bound down and the upper bound up, so the range still contains the original instant. MILLIS is still multiplied by 1000 and MICROS is unchanged. Fixes Altinity#227 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ice insert --no-copycopied ParquetTIMESTAMP_NANOSfooter min/max onto an Icebergtimestamp/timestamptzcolumn, so the manifest bounds were about 1000x too large.MILLISis still multiplied by 1000 andMICROSis unchanged.Fixes #227
Test plan
ParquetConversionsTestcovers nanosecond widening, an exact microsecond, a negative value, milliseconds, and microsecondsPartitioningTeststill passes