Skip to content

Host the health check highlight swatches centrally - #3

Merged
tpcarman merged 1 commit into
mainfrom
feature/highlight-swatches
Nov 14, 2026
Merged

tpcarman merged 1 commit into
mainfrom
feature/highlight-swatches

Conversation

@tpcarman

Copy link
Copy Markdown
Contributor

Summary

HealthCheck tables in module READMEs show each highlight colour as an image from a placeholder service: placehold.co (5 repos), place-hold.it (ESXi, Plaster template) and via.placeholder.com (Nutanix), which break. This adds central swatches and moves the READMEs onto them.

Swatches. generator/highlight-swatches.mjs renders assets/highlight-swatches/<HEX>.svg for every colour in highlight-swatches.json, plus a catalogue. They follow the brand guide's colour swatches: a 16 px square, 3 px corner and #C5D2E6 border, so pale highlights stay visible on white.

Style Critical Warning Info OK
AsBuiltReport.Core default FEDDD7 FFF4C7 E3F5FC DFF0D0
Nutanix.PrismElement (own style) F55656 FFBC0B 22A5F7 36D068

Colours follow the report, not the old image. The rollout picks the colour from the repo's style by the image's alt text (Critical, Warning, Info, OK). This fixes READMEs that show colours their report never uses. None of these modules defines its own style, so each report uses Core's colours:

Repo README showed Report uses
VMware.ESXi FFE860 / FFB38F (from PureStorage's style) FFF4C7 / FEDDD7
DellEMC.VxRail FEF3B5 / F5DBD9 (from an older style) FFF4C7 / FEDDD7
Microsoft.Azure Info D4E4F7 (in no style) E3F5FC

It also fixes one ![Citical] alt text in Azure.

Leftover branches. Azure #45 merged but left feature/readme-brand behind, and the script would have skipped the repo. It now moves such a branch forward to the base branch when it has no unmerged commits (a fast-forward, nothing lost). It still skips a branch that has unmerged commits.

Test plan

  • node --test: 15 unit tests, plus 31 checks against the live READMEs, now also asserting that no placeholder images remain
  • Dry run: 197 swatches across Azure, vSphere, ESXi, VxRail and Nutanix, none left on a placeholder service. vSphere #149 would be updated rather than duplicated
  • Checked the swatches in a table on GitHub light and dark backgrounds
  • After merge, check the workflow commits assets/highlight-swatches

🤖 Generated with Claude Code

HealthCheck tables in module READMEs show each highlight colour with an
image from a placeholder service (placehold.co, place-hold.it,
via.placeholder.com), which break. highlight-swatches.mjs renders a
swatch per highlight colour into assets/highlight-swatches/, from
highlight-swatches.json: the AsBuiltReport.Core default style, and
Nutanix.PrismElement's own style.

The README rollout replaces the placeholder images with these swatches,
in the colour the repo's report style uses. Some READMEs showed colours
from another module's style: VMware.ESXi had PureStorage's, DellEMC.VxRail
had an old style's and Microsoft.Azure had an Info colour no style
defines. All three reports use the Core style.

The rollout now reuses a leftover branch from a merged pull request when
it has no unmerged commits, by moving it forward to the base branch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant