Repository navigation
Host the health check highlight swatches centrally - #3
Merged
Merged
Conversation
HealthCheck tables in module READMEs show each highlight colour with an image from a placeholder service (placehold.co, place-hold.it, via.placeholder.com), which break. highlight-swatches.mjs renders a swatch per highlight colour into assets/highlight-swatches/, from highlight-swatches.json: the AsBuiltReport.Core default style, and Nutanix.PrismElement's own style. The README rollout replaces the placeholder images with these swatches, in the colour the repo's report style uses. Some READMEs showed colours from another module's style: VMware.ESXi had PureStorage's, DellEMC.VxRail had an old style's and Microsoft.Azure had an Info colour no style defines. All three reports use the Core style. The rollout now reuses a leftover branch from a merged pull request when it has no unmerged commits, by moving it forward to the base branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HealthCheck tables in module READMEs show each highlight colour as an image from a placeholder service:
placehold.co(5 repos),place-hold.it(ESXi, Plaster template) andvia.placeholder.com(Nutanix), which break. This adds central swatches and moves the READMEs onto them.Swatches.
generator/highlight-swatches.mjsrendersassets/highlight-swatches/<HEX>.svgfor every colour inhighlight-swatches.json, plus a catalogue. They follow the brand guide's colour swatches: a 16 px square, 3 px corner and#C5D2E6border, so pale highlights stay visible on white.FEDDD7FFF4C7E3F5FCDFF0D0F55656FFBC0B22A5F736D068Colours follow the report, not the old image. The rollout picks the colour from the repo's style by the image's alt text (
Critical,Warning,Info,OK). This fixes READMEs that show colours their report never uses. None of these modules defines its own style, so each report uses Core's colours:FFE860/FFB38F(from PureStorage's style)FFF4C7/FEDDD7FEF3B5/F5DBD9(from an older style)FFF4C7/FEDDD7D4E4F7(in no style)E3F5FCIt also fixes one
![Citical]alt text in Azure.Leftover branches. Azure #45 merged but left
feature/readme-brandbehind, and the script would have skipped the repo. It now moves such a branch forward to the base branch when it has no unmerged commits (a fast-forward, nothing lost). It still skips a branch that has unmerged commits.Test plan
node --test: 15 unit tests, plus 31 checks against the live READMEs, now also asserting that no placeholder images remainassets/highlight-swatches🤖 Generated with Claude Code