Repository navigation
fix(http): /api/raw no longer hangs when a file shrinks mid-transfer - #22
Merged
Merged
Conversation
Bun 1.4.4 can lose a stream error raised right after a chunk, leaving the connection open with no end of body. The server now waits 50 ms inside pull before the error. The test ran this race once, so it failed at random and stopped the v1.10.7 release; it now runs 25 rounds and reports a hang. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.10.7 release stopped at its test step: the
/api/rawshrinking-file test timed out, on a commit wherecihad passed. Nothing was published.Cause. This is a real hang, and it predates #21: v1.10.6 failed the same test 4 runs in 30. Bun 1.4.4 can lose a stream error raised right after a chunk, so the connection stays open with no end of body.
idleTimeout: 0never reclaims it, and a client'sblob()waits forever.Fix. Wait 50 ms inside
pullbefore the error. The delay is measured, not derived, because the cause is inside Bun.pullreturns, throw, generator, direct stream,server.timeout, padding chunkspullTest. Now 25 rounds with a watchdog. It reports
hangwithout the fix, and had no failures in 500 rounds with it. The full suite passed twice locally.DESIGN.md §25 has the details.
🤖 Generated with Claude Code