Repository navigation
Fix WASM evaluation smoke tests and derive version expectations - #322
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #321.
The WASM protocol smoke test requested every CSV column during structure evaluation, including the newly introduced prediction-only
Eens, and failed before reaching the remaining integration checks. ExcludeEensfrom evaluation, retain all-column model-P coverage, and assert the resulting CSV headers and finite ensemble energy. Add a protocol regression for accepting evaluation columns and rejectingEensin evaluation.Address the issue comment by deriving IntaRNA test versions from
configure.acand the mock engine's Boost version from the selected archive URL inscripts/wasm/build.sh. These offline tests run before Boost is installed; production provenance continues to use the compiled engine's--version. Remove the fixed IntaRNA version from the browser archive assertion and check the staged engine's version against the source configuration. UpdateChangeLog.Validation:
npm test --prefix gui: 32 tests passed.python3 scripts/wasm/test-vienna-release.py: 7 tests passed.python3 scripts/wasm/test-downloads.py: 3 tests passed.9.8.7-testand Boost1.99.2, from a different working directory: passed.git diff --check: passed.GitHub Actions passed on commit
2e12427:Deployment is intentionally skipped for pull requests.