Skip to content

Fix WASM evaluation smoke tests and derive version expectations - #322

Merged
martin-raden merged 1 commit into
masterfrom
fix/321-wasm-checks
Nov 11, 2026
Merged

martin-raden merged 1 commit into
masterfrom
fix/321-wasm-checks

Conversation

@Alexander-Mitrofanov

@Alexander-Mitrofanov Alexander-Mitrofanov commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #321.

The WASM protocol smoke test requested every CSV column during structure evaluation, including the newly introduced prediction-only Eens, and failed before reaching the remaining integration checks. Exclude Eens from evaluation, retain all-column model-P coverage, and assert the resulting CSV headers and finite ensemble energy. Add a protocol regression for accepting evaluation columns and rejecting Eens in evaluation.

Address the issue comment by deriving IntaRNA test versions from configure.ac and the mock engine's Boost version from the selected archive URL in scripts/wasm/build.sh. These offline tests run before Boost is installed; production provenance continues to use the compiled engine's --version. Remove the fixed IntaRNA version from the browser archive assertion and check the staged engine's version against the source configuration. Update ChangeLog.

Validation:

  • npm test --prefix gui: 32 tests passed.
  • python3 scripts/wasm/test-vienna-release.py: 7 tests passed.
  • python3 scripts/wasm/test-downloads.py: 3 tests passed.
  • Repeated all 7 release tests in a temporary source fixture with IntaRNA 9.8.7-test and Boost 1.99.2, from a different working directory: passed.
  • JavaScript/Python syntax checks and git diff --check: passed.
  • Independent subagent review completed; its numeric-conversion finding was corrected and the final diff approved.

GitHub Actions passed on commit 2e12427:

Deployment is intentionally skipped for pull requests.

@martin-raden
martin-raden merged commit 9dd0725 into master Nov 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WASM check/build fail

2 participants