Repository navigation
Lex use/include as keywords only before '<'; reset lexer state per parse - #17
Merged
Merged
Conversation
…e per parse As in OpenSCAD's lexer, `use` and `include` are keywords only when a `<` follows; elsewhere they are names, so `module m(include = undef)` parses. The start condition also outlived a failed parse, so the next one read text up to the first `<...>`, even in a comment, as a file name. Refs BelfrySCAD/BelfrySCAD#1138 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use/includeare keywords only when followed by<(flex trailing context), as in OpenSCAD'slexer.l; otherwise ordinary names, somodule m(include = undef)parses.lexerBeginStringresets the start condition to INITIAL. A parse that failed inside INCFILE/STR left the next parse there, which read text up to the first<...>(even in a comment) as a file name; that is the comment-line syntax errors in the report.New
UseIncludeAsNametests; 3 of 4 fail without the fix. 674 tests pass.Refs BelfrySCAD/BelfrySCAD#1138
🤖 Generated with Claude Code