Repository navigation
Conversation
Make `ExpiresSoon`, `m_loadFrequencyMs` and `m_credentials` protected so that derived providers can replace the synchronization while reusing the SDK refresh implementation and cache. The order of data members is unchanged. Validation: ClickHouse builds against it, and the gtests of its derived provider pass.
kolsha
marked this pull request as ready for review
November 16, 2026 13:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExpiresSoon,m_loadFrequencyMsandm_credentialsofGeneralHTTPCredentialsProviderbecome protected, so that a derived provider can replace the SDK locking while it reuses the SDK refresh and cache.The provider holds its
ReaderWriterLockacross the credential request. A caller that runs the request in a cooperative scheduler, where the request suspends, needs its own lock around the refresh. To do that without copying the refresh logic, the derived provider has to decide when to refresh (ExpiresSoon,m_loadFrequencyMs) and return the cached result (m_credentials), as the SDKGetAWSCredentialsdoes.Reloadis already protected.Only access specifiers change; the order of data members, and therefore the layout, is unchanged. ClickHouse builds with the same change on top of
a748a5d, and the gtests of its derived provider pass; this branch was not built on top of the currentClickHouse/1.11.907.