Repository navigation
ci: run the upstream SQL tests on a pull request with the tests:run-core-sql label - #625
Open
polyglotAI-bot wants to merge 1 commit into
Open
polyglotAI-bot wants to merge 1 commit into
polyglotAI-bot wants to merge 1 commit into
Conversation
…ore-sql label upstream-sql-tests.yml starts only on pull requests that change the harness, the workflow or the library. A new workflow, upstream-sql-tests-label.yml, calls it on any pull request when a maintainer adds the tests:run-core-sql label, and then removes the label. The `paths` filter of the pull_request trigger also applies to a `labeled` event, so the label needs a workflow of its own; upstream-sql-tests.yml gets a workflow_call trigger and no other change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AI review gate — auto-approval withheldThe AI review gate is green, but the approver did not approve What to do: ask someone with write access who is not the PR author to approve this pull request. History (latest 5 heads, newest first) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upstream-sql-tests.yml(the core SQL test harness, #621) runs nightly, by hand, and on pull requests that change the harness, the workflow, or the library (clickhouse/,contrib/,cmake/,CMakeLists.txt). Other pull requests, for example a change of the docs or of another workflow, do not start it. This PR adds thetests:run-core-sqllabel, which runs the harness on any pull request, as in ClickHouse/clickhouse-cs#749.upstream-sql-tests-label.yml: it starts onpull_requestlabeled, callsupstream-sql-tests.yml(uses: ./…) when the label istests:run-core-sql, and then removes the label. To run the tests again, add the label again.upstream-sql-tests.ymlgets aworkflow_call:trigger and one header comment line. Nothing else changes in it. A second workflow is necessary because thepathsfilter of thepull_requesttrigger also applies to alabeledevent.pull_request, notpull_request_target: the tests need no secrets, and the code of a fork runs with a read-only token. That token cannot remove the label, so theremove-labeljob skips forks (the README says to remove the label by hand there). Only theremove-labeljob haspull-requests: write; the called jobs getcontents: read, the same as the top-level permissions ofupstream-sql-tests.yml.github.workflowis the name of the calling workflow), so it does not cancel a run that a push to the same pull request started.tests/clickhouse-test-runner/README.md(CI) documents the label.tests/clickhouse-test-runner/AGENTS.mddoes not change: a client fix (rule 2) changesclickhouse/, so it already starts the workflow.The label exists in the repository now.
Checklist
.github/workflows/.native× 8 shards: all passed; thenRemove the tests:run-core-sql label). The path-triggered run of the same pull request (run 44557786370) ran at the same time and was not cancelled.🤖 Generated with Claude Code