Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
namespace StackInCSharp;
using System.Diagnostics.CodeAnalysis;

namespace StackInCSharp;

public class GenericStackHelper<T>
{
Expand Down Expand Up @@ -48,7 +50,7 @@ public T PopItem()
return GenericStack.Pop();
}

public bool TryPeekItem(out T result)
public bool TryPeekItem([MaybeNullWhen(false)] out T result)
{
if (GenericStack == null)
{
Expand All @@ -58,7 +60,7 @@ public bool TryPeekItem(out T result)
return GenericStack.TryPeek(out result);
}

public bool TryPopItem(out T result)
public bool TryPopItem([MaybeNullWhen(false)] out T result)
{
if (GenericStack == null)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public void PushItem(object o)
NonGenericStack.Push(o);
}

public object PeekItem()
public object? PeekItem()
{
if (NonGenericStack == null)
{
Expand All @@ -41,7 +41,7 @@ public object PeekItem()
return NonGenericStack.Peek();
}

public object PopItem()
public object? PopItem()
{
if (NonGenericStack == null)
{
Expand Down
35 changes: 31 additions & 4 deletions collections-csharp/StackInCSharp/StackInCSharp/Program.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
using StackInCSharp;
using System.Collections;
using System.Collections.Concurrent;

var page1 = new Page("\nThe first visited page", DateTime.Now);
var page1 = new Page("The first visited page", DateTime.Now);
var page2 = new Page("The second visited page", DateTime.Now);

var nonGenericStackHelper = new NonGenericStackHelper();
Expand Down Expand Up @@ -46,8 +47,8 @@
result = genericStackHelper.TryPopItem(out topPage);

Console.WriteLine($"\nTryPop() METHOD");
Console.WriteLine($"TryPop returns: {result}");
Console.WriteLine($"the title of the topPage in pageStack is: {topPage?.Title}");
Console.WriteLine($"TryPop returns: {result}");
Console.WriteLine($"the title of the topPage in pageStack was: {topPage?.Title}");
genericStackHelper.PrintCount();

nonGenericStackHelper.ClearStack();
Expand All @@ -61,4 +62,30 @@

Console.WriteLine($"Thread-safety for non-generic case");
Console.WriteLine($"{nameof(nonGenericStackHelper.NonGenericStack)} is thread-safe: {nonGenericStackHelper.IsSynchronizedStack(nonGenericStackHelper.NonGenericStack)}");
Console.WriteLine($"{nameof(synchronizedStack)} is thread-safe: {nonGenericStackHelper.IsSynchronizedStack(synchronizedStack)}");
Console.WriteLine($"{nameof(synchronizedStack)} is thread-safe: {nonGenericStackHelper.IsSynchronizedStack(synchronizedStack)}");

Console.WriteLine($"\nConstructor ORDER");
List<string> letters = ["a", "b", "c"];
Stack<string> lettersFromList = new Stack<string>(letters);
Console.WriteLine(lettersFromList.Peek());
Console.WriteLine(string.Join(", ", lettersFromList));

Console.WriteLine($"\nEMPTY STACK");
var undoStack = new Stack<string>();
Console.WriteLine($"Is the stack empty? {undoStack.Count == 0}");

undoStack.Push("Type 'Hello'");
undoStack.Push("Make it bold");
undoStack.Push("Delete a word");

while (undoStack.TryPop(out var action))
{
Console.WriteLine($"Undo: {action}");
}

Console.WriteLine($"Is the stack empty? {undoStack.Count == 0}");

Console.WriteLine($"\nConcurrentStack");
var threadSafePageStack = new ConcurrentStack<Page>();
Parallel.For(0, 100, i => threadSafePageStack.Push(new Page($"Page {i}", DateTime.Now)));
Console.WriteLine($"threadSafePageStack contains {threadSafePageStack.Count} items");
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
Expand Down
24 changes: 24 additions & 0 deletions collections-csharp/StackInCSharp/Tests/StackInCSharpUnitTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -151,4 +151,28 @@ public void GivenGenerickStack_WhenClear_ThenTheStackIsEmpty()

Assert.Empty(_genericStackHelper.GenericStack);
}

[Fact]
public void GivenEmptyGenericStack_WhenTryPop_ThenItReturnsFalse()
{
var popped = _genericStackHelper.TryPopItem(out var page);

Assert.False(popped);
Assert.Null(page);
}

[Fact]
public void GivenEmptyGenericStack_WhenPeek_ThenItThrows()
{
Assert.Throws<InvalidOperationException>(() => _genericStackHelper.PeekItem());
}

[Fact]
public void GivenAList_WhenStackIsCreatedFromIt_ThenTheLastElementIsOnTop()
{
var stack = new System.Collections.Generic.Stack<string>(["a", "b", "c"]);

Assert.Equal("c", stack.Peek());
Assert.Equal(["c", "b", "a"], stack.ToArray());
}
}
10 changes: 5 additions & 5 deletions collections-csharp/StackInCSharp/Tests/Tests.csproj
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<Nullable>enable</Nullable>

<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.11.0" />
<PackageReference Include="xunit" Version="2.4.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.11.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="4.0.1">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="coverlet.collector" Version="3.1.0">
<PackageReference Include="coverlet.collector" Version="10.1.0">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
Loading