Repository navigation
Bucket Sort: .NET 10, corrected algorithm and copy-per-call benchmark - #2371
Merged
vladimir-pecanac-main merged 2 commits intoNov 12, 2026
Conversation
…per-call benchmark Targets net10.0 with BenchmarkDotNet 0.15.8 and MSTest 4.5.2. SortArray now scales each value's distance from the minimum to the bucket count with long arithmetic and checks the base case first; BubbleSort compares neighbours; SortArrayOptimized uses a long range and a nullable node. The benchmark moves to BucketSortBenchmarks, copies its input per call and adds an Array.Sort baseline. New edge-case, full-range and random tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the BucketSort sample to net10.0 with BenchmarkDotNet 0.15.8, MSTest 4.5.2, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0. SortArray picked a bucket with array[i] / numberOfBuckets, which threw on inputs such as {100, 101}, negatives and empty arrays and put almost every value into one bucket; it now scales each value's distance from the minimum to the bucket count in long arithmetic, checks the base case before reading array[0], and BubbleSort is a real neighbour-comparing bubble sort. SortArrayOptimized computes its range as a long and uses a nullable node. The benchmarks move to a separate BucketSortBenchmarks class that copies its input per call and adds an Array.Sort baseline, Program.cs passes args to BenchmarkRunner, and the tests cover edge cases, the full int range and a seeded random array against Array.Sort.