Repository navigation
Counting Sort: net10.0, copy-per-call benchmark, stable counting sort - #2373
Merged
vladimir-pecanac-main merged 4 commits intoNov 12, 2026
Conversation
…ng sort Targets net10.0 with BenchmarkDotNet 0.15.8, MSTest 4.5.2, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0. CountingSort() drops the benchmark-only parameter and the zeroing loop and returns empty input at once. Adds StableCountingSort<T>() with a long key range and an Array.MaxLength guard. The benchmark moves to CountingSortBenchmarks, copies its input per call and uses Array.Sort() as the baseline; the worst case outlier is 2,000,000 instead of Int32.MaxValue / 2. Tests use (expected, actual) order and cover the article example, empty, negative and stable cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves csharp-algorithms/CountingSort to net10.0 with BenchmarkDotNet 0.15.8, MSTest 4.5.2, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0, removes the benchmark-only parameter and the redundant zeroing loop from CountingSort(), returns empty input at once, adds a stable StableCountingSort() that handles negative keys with a long range guard, moves the benchmark into its own class that copies its input on every call and compares against Array.Sort(), replaces the 4 GB worst-case outlier with 2,000,000, and replaces the two weak tests with tests for the article example, random input, empty and negative input and the stable sort.