Repository navigation
SortingGenericList: .NET 10, comparer null contract fix, IndexOf duplicates - #2377
Merged
vladimir-pecanac-main merged 1 commit intoNov 9, 2026
Conversation
…act and IndexOf duplicates Target net10.0, update xunit 2.9.3, xunit.runner.visualstudio 4.0.1, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0, and replace FluentAssertions with plain xUnit asserts. DescendingCompare goes through Comparer<Product>.Default so two nulls compare as equal, MySortedList.IndexOf returns the first of several equal items, and Program.cs gains a Comparer<T>.Create example. Four new tests cover the fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves collections-lists/SortingGenericList to net10.0 with xunit 2.9.3, xunit.runner.visualstudio 4.0.1, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0, and replaces FluentAssertions with plain xUnit asserts under the same test names. Product.DescendingCompare now goes through Comparer.Default so two null products compare as equal (the old form returned -1 and List.Sort threw on lists with many nulls), MySortedList.IndexOf returns the first of several equal items, Program.cs adds a Comparer.Create example, and four new tests cover these cases (57 tests in total).