Repository navigation
ObjectComparison: .NET 10, null-safe comparers, copy-per-call benchmark - #2378
Open
vladimir-pecanac-main wants to merge 1 commit into
Conversation
Targets net10.0 with BenchmarkDotNet 0.15.8, xunit 2.9.3, xunit.runner.visualstudio 4.0.1, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0. The comparers and Comparison delegate methods now sort nulls first instead of returning 0, the benchmark copies a shuffled source before each sort, Program.cs adds a lambda sort by Name and passes args to BenchmarkRunner, and the tests cover descending order, the lambda, nulls, random input and SortedSet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the ObjectComparison sample to net10.0 with current BenchmarkDotNet, xunit and test SDK packages. The IComparer helpers and the Comparison delegate methods now put nulls first instead of returning 0, which broke the comparison contract and left arrays with nulls unsorted. The benchmark copies a shuffled source into a working array before each sort, so every call sorts unsorted data, and tests two sizes. Program.cs adds a lambda sort by Name and passes args to BenchmarkRunner, and the tests now check exact orders, nulls, random input and SortedSet with Comparer.Create.