Skip to content

Two nodes with the same container name are accepted; build silently loses one #711

Open

Description

@yadavchiragg

If two nodes share a container name but have different source files (e.g. "ctrl:a.py" and "ctrl:b.py"):

  • mkconcore.py exits 0
  • the generated build script fails with "mkdir: cannot create directory 'ctrl': File exists", and ./build itself still exits 0
  • one of the nodes is silently lost
  • concore validate reports "Workflow is valid and ready to run"

mkconcore and validate already reject two nodes with the identical label, but not the same container name with different sources, even though both map to the same directory.

Proposal: reject this in both places with a clear message that names the container and the labels, and give it its own error type in validate --format json. None of the sample workflows in the repo has duplicate container names. I have a fix and tests ready.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions