Skip to content

Reject nodes that share a container name in mkconcore and validate - #712

Open
yadavchiragg wants to merge 1 commit into
ControlCore-Project:devfrom
yadavchiragg:fix/duplicate-container-names
Open

yadavchiragg wants to merge 1 commit into
ControlCore-Project:devfrom
yadavchiragg:fix/duplicate-container-names

Conversation

@yadavchiragg

Copy link
Copy Markdown

Fixes #711

Two nodes with the same container name but different source files (e.g. ctrl:a.py and ctrl:b.py) share one directory. mkconcore exited 0, the generated build failed with "mkdir: cannot create directory 'ctrl': File exists" (while also exiting 0), one node was lost, and concore validate reported the workflow as valid.

  • mkconcore.py now logs "Container name 'ctrl' is used by more than one node: ..." and exits 1.
  • concore validate reports "Duplicate node container name: ..." as an error, with error_type duplicate_container_name in --format json.
  • The existing identical-label checks are unchanged. None of the sample .graphml files in the repo is affected.

Added tests/test_duplicate_container_names.py (mkconcore and validate, duplicate and distinct names); the duplicate cases fail without the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant