Repository navigation
Reject nodes that share a container name in mkconcore and validate - #712
Open
yadavchiragg wants to merge 1 commit into
Open
yadavchiragg wants to merge 1 commit into
yadavchiragg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #711
Two nodes with the same container name but different source files (e.g. ctrl:a.py and ctrl:b.py) share one directory. mkconcore exited 0, the generated build failed with "mkdir: cannot create directory 'ctrl': File exists" (while also exiting 0), one node was lost, and
concore validatereported the workflow as valid.concore validatereports "Duplicate node container name: ..." as an error, with error_type duplicate_container_name in --format json.Added tests/test_duplicate_container_names.py (mkconcore and validate, duplicate and distinct names); the duplicate cases fail without the change.