Repository navigation
fix: add explicit timeout policy for generated project test workflows - #430
Open
Halimatyemisi wants to merge 2 commits into
Open
Halimatyemisi wants to merge 2 commits into
Halimatyemisi wants to merge 2 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Author
|
this PR is ready for another review. I resolved the merge conflicts with the main branch (pushed 2e59384). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds an explicit, bounded timeout policy for
stellarforge testso a hung generated-project test command cannot block a developer indefinitely. It introduces a documented default timeout, a future-safe internal option boundary, bounded child-process-tree termination with a grace period, and clear timeout-vs-failure signaling in exit codes and output. The timeout is scoped totestonly and does not affectdevunless explicitly configured there.Related Issue
Changes
⏱️ Timeout Policy for Generated-Project Tests
[MODIFY]
src/testing/project.ts[MODIFY]
src/commands/test.tstestcommand path.[MODIFY]
docs/reference/configuration.md[MODIFY]
docs/reference/exit-codes.md🧪 Tests
[MODIFY]
tests/test-project.test.ts[MODIFY]
tests/test-workflow-platform-and-exit.test.tsVerification Results
docs/reference/configuration.md; internal option boundary insrc/testing/project.tsdocs/reference/exit-codes.md; covered in testsdevunless explicitly configured theretestcommand pathtests/test-project.test.tsandtests/test-workflow-platform-and-exit.test.tsCloses #339