Skip to content

fix: add smart contract template integrity checks - #442

Open
Vitalis-Okenwa wants to merge 2 commits into
DigiNodes:mainfrom
Vitalis-Okenwa:fix/sw-145-source-integrity
Open

Vitalis-Okenwa wants to merge 2 commits into
DigiNodes:mainfrom
Vitalis-Okenwa:fix/sw-145-source-integrity

Conversation

@Vitalis-Okenwa

@Vitalis-Okenwa Vitalis-Okenwa commented Nov 20, 2026 •

Copy link
Copy Markdown

Summary

Implements SW-145 Smart Contract template source and dependency integrity checks.

Related Issue

Closes #326

Scope

  • Adds deterministic Smart Contract template source-integrity checks.
  • Validates dependency declarations against the approved policy.
  • Ensures required template files are included in the published npm package.
  • Renames the template gitignore source file so npm includes it, then restores .gitignore in generated projects.
  • Adds regression tests for package contents and generated output.

Testing

  • 4 focused test files passed.
  • 40 tests passed, 0 failed.
  • No new dependencies added.

Security Impact

  • Security-sensitive behavior is changed and explained below.

Security notes:

Adds regression coverage for dependency and source integrity. No credentials or secrets added.

Release Impact

  • Patch
  • Changeset not required; reason explained below.

Release notes:

Generated Smart Contract projects now correctly receive their .gitignore file. No new dependency or changeset was required for this fix.

Documentation

  • No documentation change required.

Checklist

  • I read docs/contributing/wave-architecture.md for Stellar Wave work
  • I stayed within the agreed issue scope
  • I checked for overlapping open contributor PRs
  • I did not include secrets or sensitive data
  • I reviewed new/updated dependencies if any
  • I considered failure/error paths, not only the happy path
  • I am not disclosing an unresolved vulnerability publicly

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d7d55fad-b84a-454b-8c7e-8d47e5f417cf
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Vitalis-Okenwa

Copy link
Copy Markdown
Author

The upstream synchronization is complete, and I've pushed the updated branch. The local TypeScript build and all 63 focused tests pass.

The GitHub Actions workflows are currently awaiting maintainer approval. Please approve the workflow runs so CI and the remaining checks can execute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SW-145 — Add Smart Contract template source and dependency integrity checks

1 participant