Skip to content

Add configuration file schema version migration policy - #444

Open
sunnykid-02 wants to merge 1 commit into
DigiNodes:mainfrom
sunnykid-02:migration-policy
Open

sunnykid-02 wants to merge 1 commit into
DigiNodes:mainfrom
sunnykid-02:migration-policy

Conversation

@sunnykid-02

Copy link
Copy Markdown

Summary

Implemented forward-version rejection in src/config/schema.ts:62 (missing → required error, malformed → positive-integer error, future → actionable upgrade error with detected version), added tests/config-schema-version.test.ts with unit, integration, and fast-check property coverage, and documented the policy in docs/reference/configuration.md:70. Version 1 behavior is unchanged.
Verification: all 333 config-related tests pass, including the new 18; changed files pass ESLint and Prettier. Repo-wide npm run typecheck, npm run lint, format:check, and parts of the full suite fail on pre-existing issues in untouched files (e.g. tests/quick-start-docs.test.ts, template/generator timeouts, CRLF formatting), so those CI gates are not green from this change alone.

Related Issue

Closes #341

Scope

Testing

  • Tests added/updated where applicable
  • Existing relevant tests pass
  • Lint/type/build checks pass where available

Security Impact

  • No security-sensitive behavior is changed
  • Security-sensitive behavior is changed and explained below

Security notes:

Release Impact

  • No published/user-visible behavior change

  • Patch

  • Minor

  • Breaking/pre-1.0 contract change

  • Changeset included where required

  • Changeset not required; reason explained below

Release notes:

Documentation

  • Documentation updated where applicable
  • No documentation change required

Checklist

  • I read docs/contributing/wave-architecture.md for Stellar Wave work
  • I stayed within the agreed issue scope
  • I checked for overlapping open contributor PRs
  • I did not include secrets or sensitive data
  • I reviewed new/updated dependencies if any
  • I considered failure/error paths, not only the happy path
  • I am not disclosing an unresolved vulnerability publicly

@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2dc12d7b-e5cf-4b70-ac53-8298f46c66c7
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SW-160 — Add configuration file schema version migration policy

1 participant