Repository navigation
Conversation
A linting configuration written for an earlier release may still name a rule this linter has since retired in ignoreDiagnostics. That line was refused as LOC0020, an error, failing every run, while a project pinned to the earlier release could not drop the line until it moved to the new one. Locali's own CI, linting Forma with the build under test, sat in exactly that gap whenever a rule was retired. Such a line is now LOC0021, a warning that it leaves nothing out, so the configuration keeps passing across the release and the line goes when the project bumps its pin. An identifier no release ever defined is still refused as LOC0020.
LOC0208, LOC0214 and LOC0215 reported Locali's own blind spots as warnings: a key written as an expression, a key a parameter takes that some call writes otherwise, and a lookup from which no path reaches a type. None of them is a defect, and what they cover is decided only while the app runs. They are retired, LOC0208 at a library's public method included. Each such lookup is now counted unchecked in the coverage and listed in the JSON report with its place, its reasons and what kept it unchecked; for a library's public method whose key its consumers write, the explanation names the key hint that lets their runs check those calls. The console summary says how many went unchecked. BREAKING CHANGE: LOC0208, LOC0214 and LOC0215 are no longer reported, a configuration still naming them gets a LOC0021 warning, and the coverage's lookup count now takes in keys written as expressions and keys taken from parameters some call writes otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes candidate at 90802b8, whose full gate passed in run 44080294473, to main for the release of 1.0.0-preview.23. The changes are in the changelog's 1.0.0-preview.23 entry.