Repository navigation
Conversation
Adds complexity (10), max-depth (3), max-params (3), no-else-return, no-nested-ternary, no-param-reassign (props), import/no-cycle and typescript/switch-exhaustiveness-check as warnings. The size and style rules are off in tests and stories.
Adds native jsdoc rules (check-tag-names, no-defaults, require-param for blocks that already list params, param and returns descriptions) and eslint-plugin-jsdoc as the jsdoc-js JS plugin for no-types, check-param-names and require-hyphen-before-param-description. No rule requires a doc block.
🦋 Changeset detectedLatest commit: 485ef68 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
In plain JS, JSDoc braces are the only type information.
🦋 Changeset detectedLatest commit: 9bcae32 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jcosta33
changed the title
jcosta33
changed the title
jcosta33
marked this pull request as ready for review
November 9, 2026 14:30
Require unions to list every case, share one test glob list, apply no-empty and no-useless-catch to TypeScript, and add unicorn/no-array-reduce and eslint-comments/require-description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds code-quality and JSDoc rules to
@frontify/oxlint-config-basic(and so@frontify/oxlint-config-react).Errors, cheap to fix:
no-nested-ternary,no-else-return: keep branches flat.typescript/switch-exhaustiveness-check: TypeScript only catches a missingcasewhen the switch must return a value; this covers the rest, so adding a union member flags every switch that misses it. Adefaultdoes not count as covering a union.unicorn/no-array-reduce: a loop reads clearer.eslint-comments/require-description: every lint exception says why.no-empty,no-useless-catch: no swallowed errors. They applied to JS files only; now TypeScript too.@default,@param name - meaning,@returns meaning, no{Type}braces (TypeScript files only). No rule requires a doc block. The rules oxlint lacks natively come fromeslint-plugin-jsdoc, loaded asjsdoc-js.Warnings, to raise to errors once consumers clear them, since fixing them takes judgment:
complexity(10),max-depth(3),max-params(3): flag functions that do too much to read or test.no-param-reassign(props: true): no hidden mutation of arguments.complexity,max-depth,max-params,no-else-return,no-nested-ternaryandno-param-reassignare off in tests and stories, which favour readable inline fixtures.import/no-cycleis left out: it is slow and repeats dependency-cruiser.Oxlint lints whole files, so a repo bumping to this version must clear the errors in its bump PR (
oxlint --fixdoes most) or set rules towarnlocally.