Skip to content

feat(bigquery): add bigquery_query_biglake_gcs_temp_table sample to q… - #14752

Merged
iennae merged 2 commits into
mainfrom
feat/bq-query-biglake-gcs-temp-table
Nov 17, 2026
Merged

iennae merged 2 commits into
mainfrom
feat/bq-query-biglake-gcs-temp-table

Conversation

@iennae

@iennae iennae commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

…uery a temporary BigLake table on Cloud Storage

Problem:
The BigQuery documentation (https://cloud.google.com/bigquery/docs/query-cloud-storage-using-biglake) needs a standalone, tested Python code sample demonstrating how to query a temporary BigLake table on Cloud Storage (region tag bigquery_query_biglake_gcs_temp_table).

Solution:

  • Add query_biglake_gcs_temp_table(project_id: str, connection_id: str) -> None in bigquery/biglake/bigquery_query_biglake_gcs_temp_table.py (Configure an ephemeral BigLake table definition over Cloud Storage files using ExternalConfig and query it within a single job.)
  • Add unit tests (bigquery/biglake/bigquery_query_biglake_gcs_temp_table_test.py) covering both the success path and API error handling (GoogleAPICallError)

Description

Fixes #

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.

Compliance & Style


Post-Approval Actions

  • Please merge this PR for me once it is approved

@iennae
iennae requested review from a team and chalmerlowe as code owners November 2, 2026 23:31
@snippet-bot

snippet-bot Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added api: bigquery Issues related to the BigQuery API. samples Issues that are directly related to samples. labels Nov 2, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Python sample for configuring and querying a temporary BigLake table backed by Cloud Storage, along with its corresponding unit tests and configuration files. The feedback recommends updating the ignored_versions in noxfile_config.py to ensure that only the oldest and newest supported Python versions are tested, which means Python 3.10 should not be ignored.


TEST_CONFIG_OVERRIDE = {
# You can opt out from the test for specific Python versions.
"ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the repository's general rules, we should only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions. Since Python 3.10 is the oldest supported version (as indicated by requirements-test.txt), it should not be ignored. Assuming Python 3.13 is the newest supported version, we should ignore intermediate versions like 3.11 and 3.12 instead.

Suggested change
"ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"],
"ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.11", "3.12"],
References
  1. Only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions.

@iennae
iennae force-pushed the feat/bq-query-biglake-gcs-temp-table branch 3 times, most recently from 442f921 to 16d3640 Compare November 3, 2026 23:32

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…uery a temporary BigLake table on Cloud Storage

Problem:
The BigQuery documentation (https://cloud.google.com/bigquery/docs/query-cloud-storage-using-biglake)
needs a standalone, tested Python code sample demonstrating how to
query a temporary BigLake table on Cloud Storage (region tag `bigquery_query_biglake_gcs_temp_table`).

Solution:
- Add `query_biglake_gcs_temp_table(project_id: str, connection_id: str) -> None` in `bigquery/biglake/bigquery_query_biglake_gcs_temp_table.py`
  (Configure an ephemeral BigLake table definition over Cloud Storage files using ExternalConfig and query it within a single job.)
- Add unit tests (`bigquery/biglake/bigquery_query_biglake_gcs_temp_table_test.py`) covering both the success
  path and API error handling (`GoogleAPICallError`)
@iennae
iennae force-pushed the feat/bq-query-biglake-gcs-temp-table branch from 16d3640 to 2e76dcc Compare November 17, 2026 04:57
…gcs_temp_table tests

Problem:
The tests replaced the client class with `lambda project=None: mock_client`.
A lambda only accepts that one keyword, so the test would break for reasons
unrelated to the sample if the constructor call changed, and it records
nothing, so the tests could not verify how the client was created.

Solution:
Patch the client class with `mock.MagicMock(return_value=mock_client)` and
assert in the success test that the sample constructed it exactly once with
the expected arguments.
@iennae
iennae merged commit 56585c4 into main Nov 17, 2026
14 of 19 checks passed
@iennae
iennae deleted the feat/bq-query-biglake-gcs-temp-table branch November 17, 2026 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants