Repository navigation
ci: fix the Welcome inputs and the Development trigger - #1
Merged
Merged
Conversation
actions/first-interaction@v3 reads `repo_token`, `issue_message` and `pr_message`, all required by its code. The workflow still passed the v1 names `repo-token` and `pr-message`, so the Welcome job failed with "Input required and not supplied: issue_message" on every newly opened pull request in the org. Rename the inputs and add an issue message. The workflow only runs on pull requests, so that message is never posted; v3 requires it anyway.
1 of 11 tasks
It also ran on pull requests to this repository, which has no package.json or lockfile, so its npm install failed and every pull request here showed Test application and Code standards as failing. Repositories that call it through workflow_call run it as before.
0-vortex
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The shared Compliance workflow's Welcome job fails on every newly opened PR in the org. It passes the v1 input names
repo-tokenandpr-messagetoactions/first-interaction@v3, which readsrepo_token,issue_messageandpr_messageand requires all three in its code. The job log on HyperCubeSphere/release#2 showsUnexpected input(s) 'repo-token', 'pr-message', thenInput required and not supplied: issue_message.This renames the inputs and adds an issue message in the same tone. The workflow only runs on pull requests, so that message is never posted; v3 requires it anyway.
It also stops
development.ymlfrom running on this repository's own pull requests. It triggered onpull_requestas well asworkflow_call, but this repository has nopackage.jsonor lockfile, so its npm install failed and every PR here showed Test application and Code standards as failing. Repositories that call it throughworkflow_callrun it as before.Closes # (no issue; found on HyperCubeSphere/release#2)
Type
Checklist
action.ymlandsrc/main.tsAI-assistance
An agent prepared the input rename after reading the failing job log and the action's v3 source.
Screenshots / recordings
None.
Post-deployment
This PR's own Welcome check will still fail:
pull_request_targetruns the workflow frommain, not from this branch. The fix shows on the first PR opened after this merges, in any repo that calls this workflow.Since the second commit, this PR no longer runs Test application or Code standards.