Repository navigation
§ 5.2, § 5.9 — Video and audio: programs, break position, and the audio feed (#99, #100, #101) - #150
Open
KonstantinMirin wants to merge 267 commits into
Open
KonstantinMirin wants to merge 267 commits into
KonstantinMirin wants to merge 267 commits into
Conversation
Read the media condition from the ad served when an impression accepts several media, name the seller as the party that serves, place linear TV outside the table, and state environments as (distribution channel, device type) pairs. Insert environments.available[] into the summary list without rewrapping it, shorten the changelog entry and drop audio_streaming from OQ-7 in docs/open-questions.md. Refs IABTechLab#90
Move the summary rule out of the § 2.1 key list, drop skip from the CTV example, and mark the CHANGELOG entry as breaking.
time_zone is the line item's clock for daypart windows and
frequency_cap.period: an IANA time zone name or viewer_local. A window
is { days[], start, end } in civil time with an exclusive end later
than start, up to 24:00; a window that crosses midnight is two windows.
List the `days[]` values once in the `daypart` row, as `monday` | ... | `sunday`. Write HH:MM, America/New_York, and UTC as plain text, since they're a format and examples, not field names. The meaning is unchanged.
"At least one of" an empty list is never satisfied, so the bonus line would fail a literal check. An absent key sets no condition. Only the examples change; the any_of[] row and the rules stay as filed in IABTechLab#23. Refs IABTechLab#23
The floor row now says it "neither constrains nor describes the downstream auction floor", as IABTechLab#16 asked, and names that floor: the per-impression floor the exchange applies at auction time (OpenRTB 2.6 Imp.bidfloor). Refs IABTechLab#16
From the Postindustria review on IABTechLab#73: - a replay matches on the same body, every value the buyer sent except idempotency_key, and returns the stored result whether an acceptance or a rejection; a retry against a new version uses a new key; - version increments on each revision of the proposal, not only while published, so a counter under review also moves it; - "deterministic" now says what the checks depend on: the stored proposal and the time the seller receives the attempt; - the price check names the pricing[] entry the commitment is priced against. Refs IABTechLab#24
Give each repeated concept one type in section 2.2, and state the table, presence, type, key, and value rules in section 2.6. Add Type and Required columns to every field and key table. Add the lifecycle, recorded, asserted, and mixed markers, and a line_items[] field. Define the Summary as a strict path subset, with manifest key tables. Delete catalog_ref. Rename the time, reference, delta, cap, and path fields to use the shared types. Number every heading, and keep issue citations and edit history out of normative text. Update the examples, the manifest, the appendices, and the docs. Teach check_appendix.py the new columns and a closed layout list, and add check_examples.py, which checks the examples against the spec's tables.
Add section 2.4: a rejection returns errors[], one or more ErrorObjects with an open code list, retry values that read for any request, and informative HTTP fits. Name the code each rejection in sections 5.5, 5.6.1, and 5.6.3 returns, and drop the requires cycle ban. Add the Ext type and section 2.5: ext on the proposal and each line item, keyed by owner domain, ignored and kept when not understood, and frozen at agreed. Make spec_version a required proposal field, and ask in section 8 how a receiver reads a later release. Add informative security considerations in section 2.7. Word the open questions without a count. Update the examples and appendices, and teach check_examples.py the Ext type and the open ErrorObject.
Make seller a Party in section 4.1, with a required legal_name, and add
buyer and commitment.advertisers[]. Move the registry_id rules to Party
in section 2.2, and scope proposal_id to seller.domain.
Add section 1.2 with the three identity layers. In section 5.8, require
visibility, define each value, and separate who may read from who may
commit. Eligibility is a resolve step that returns not_eligible, and an
unreadable line item returns not_found. A required credential is
{ credential_type, issuer }, and eligible_bidders[] splits into
eligible_buyers[] and eligible_seats[].
Give buyer_requirements, billing, and agreement key tables, and convert
the rows the terms and agreement change added. In section 2.3, drop the
manifest seller_id and filter on status, and ask in section 8 whether a
manifest needs both validators. Update the examples, appendices, and
checkers.
# Conflicts: # examples/proposal.yaml # spec/openproposal-3.0.md
Separate shared and issued proposals, and add issued_from. Define the binding record, record_digest, and assent[] entries, freeze a version's offered terms, and state one staleness rule for asks and holds. Give each act one history action, name the status types, make the line-item transitions exhaustive, define a firm entry per pricing entry, and list the allowed decline grounds once. State agreed once. Remove buyer state from the shared examples, add an issued, partly agreed example, and recompute its record_digest in the checker.
# Conflicts: # CONTRIBUTING.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Draft 1 can't say where in a break an ad plays, or which show or game it runs in. Nor can it name the audio feed, or say if the ad is recorded into the content.
placementgets aPlacementkey table (§ 5.2.2), withfeedandssai. It is REQUIRED on avideooraudioline item, andplcmtonvideo.break_positionoptions, whichavailabilityrecomputes against (§ 3.3).Contentand a LEAPEventSchedule. It says what happens when an event doesn't air.content_detailis removed.episodesis its own field, REQUIRED on a podcast or catch-up radio feed.dai,scheduled, andembeddedfor every channel, and the rules for anembeddedline item. A buyer can ask for an embedded line item'sretention, from @jaanijuk and CRA.RequestedValuegainsretention, so a request can carry the retention it asks for.creative_delivery.protocols[]takes AdCOM Creative Subtypes codes, andother_protocols[]takes terms. They replaceprotocolandthird_party_tags.ProductionOptionlosescost, sincedeltasprices a build, andbuild_ownerbecomesbuilt_by.ctvline item that carriesplcmttoadtypes2. New § 6.10 and § 6.11 show an embedded podcast and a live event series.Related issue
Closes #99. Closes #100. Closes #101.
Refs #89, #120, and #121.
Builds on
This PR builds on our placement PR (#120), which merges first, and our DOOH PR. It builds on our settlement PR, our pricing PR, our handoff PR, our post-agreement PR, and our holds PR. Those build on our signing PR, buyer writes PR, lifecycle PR, parties PR, errors and extensions PR, and shared types PR. Through them it carries #18, #70, #71, and #72 by @Sirajmx, #73 to #76 by @Kishore-2572, and #117 and #118 by @aleksUIX. Review the commits "Define video and audio placement, programs, and break position", "Name the advertiser in the embedded podcast example", "Let a buyer ask for a retention", "Count retention among the requestable fields", "Let a request carry the retention it asks for", and "Record the video and audio changes the changelog left out".
Type
Checklist
programs,episodes,break_position, andretention;content_detailandthird_party_tagsremoved;placementandcontrolling_measurementrows updated.scripts/check_appendix.pypassesselectablegoes from 14 to 16, and the field count from 97 to 99.seller-setgoes from 47 to 46:episodesin,content_detailandthird_party_tagsout.requestablegoes from 5 to 6 withretention.examples/is updated and still parses — newline-item-podcast-embedded.yaml(§ 6.10) andline-item-ctv-live-series.yaml(§ 6.11).line-item-rewarded-video.yaml(§ 6.7) uses the current field names. The CTV examples gainplacement.ssaiandserving_mode: dai, § 6.3 gains pricedbreak_positionoptions, and the audio example gainsplacement.feed. Bothrecord_digestvalues are recomputed, andmanifest.jsonis regenerated.scripts/check_examples.pychecks tentative events and theembeddedrules, and passes.scripts/check_pricing_fixtures.pypasses 60 of 60selectabledeclaresavailable[]andincluded[]; anythingsettabledeclares bounds (§ 3.1, § 3.2) —programsandbreak_positiondeclare both; no newsettablefieldsKnock-on effects
content_detail,third_party_tags,creative_delivery.protocol,production.available[].cost,build_owner,serving_modeclient_sideorssai, orsource_type0no longer conforms. Avideooraudioline item needsplacement, withplcmton video andfeedon audio. Anembeddedline item needsretentionandcontrolling_measurement.feedandepisodes. Hereepisodesleaves free-textcontent_detail. Their per-episode categories stay with [Change] § 5.2, § 5.5: Structured content categories (taxonomy_ref) on inventory, and a contextual targeting bound #48.content, andscheduletakesInstanttimes. Over OpenRTB 2.6,contentvalues take OpenRTB key names, such aslivestream.episodesstands alone, answering [Change] § 5.2 — Make programs and live events selectable, and say what happens when one doesn't air #100 question 5 and [Change] § 5.2, § 5.9 — Audio: name the feed, and say when an ad is recorded into the content #101 question 3.serving_modehas three core terms, andplacement.ssaistates server-side insertion. Anembeddedline item omitsmarkets.plcmtis REQUIRED only onvideo. Onctvits presence states video, answering its question 7.placementmoves to § 5.2.2, and the OM SDK rule readsmeasured_by.reward,instl, andskiptakeIntegerFlag, and § 6.5 becomes § 6.7.placementandrefreshgain key tables, as its rule 2 asks.programsis § 5.2.9. Our formats PR reconciles the two with our audience PR.Open questions
final_afteris OPTIONAL. Without it, § 5.9 sets no end to post-flight counting on anembeddedline item, and § 5.7.1 leaves that toterms_refs[]. Shouldembeddedrequirefinal_after? This extends [Change] § 5.2, § 5.9 — Audio: name the feed, and say when an ad is recorded into the content #101 question 4.placement.feed, as on avideoline item, every copy the seller distributes counts toward delivery underretention. Should anembeddedvideoline item name which copies count?ssai: 0, which AdCOM defines as status unknown?Contribution Terms
Analyzed and generated with the help of Claude, fully reviewed by me.