Repository navigation
DO NOT MERGE: Axum integration RC - #462
Draft
ChristianPavilonis wants to merge 767 commits into
Draft
ChristianPavilonis wants to merge 767 commits into
ChristianPavilonis wants to merge 767 commits into
Conversation
Capture bounded request-owned SDK head, read and release observations on Axum and Cloudflare test builds. Bind cutoff evidence to the prepared URI, clock and budget without changing production policies. Preserve strict timing and record the remaining Miniflare 5 runtime verification gap. Validate fixture root paths before native runtime construction.
Keep the SDK body-read regression aligned with the hard-cut naming guard. Preserve the guard, original timing and all test behavior.
Use a bounded staged-file inventory with the selected SDK rule matcher and explicit-module converter. Preserve namespace identity, persistence and owned shutdown without a legacy runtime fallback. Record passing smoke and restart checks separately from retained cold-case lifetime timing failures. Keep qualification and capability levels unchanged.
Reuse the request-owned core witness at the raw WASI read and complete source-owner boundaries. Require native evidence for Spin pending-cutoff fixtures without changing production transport, timing or limits. Record passing root, native, pinned SDK and harness checks separately from retained lifetime timing failures. Keep Fastly native-wait and hosted qualification gates open.
Bind request-owned observations to the exact submitted SDK body handles and share a resource-before-release test owner with stream witnesses. Validate native wait outcomes, chronology and call counts without additional SDK probes or production policy changes. Retain strict timing failures and separate local characterization from exact-candidate and hosted qualification.
…, paginated artifact selection, registry guards, simplified Node setup, focused tests and documentation cleanup. No new dependencies.
Extend the existing lifetime fixture and bounded wire origin with the required 100/800 ms streamed-body scenario. Observe the original batch only after EOF and validate arrival-based results, original cutoff, source framing and nonoverlapping operation records. Keep the expanded runtime inventory unqualified with both strict timing failures recorded. No production API, runtime pin, capability or CI invocation changes.
Exercise original origin streams alongside a pending bidder body and Send after batch creation through the existing lifetime fixture. Bound and validate actual read/Next-return observations, cutoff timing, arrival attribution and source framing without another transport or scheduler. Reject missing EOF evidence and waits that do not overlap continuing reads. Both new local cases pass; retain full-inventory timing failures and open exact-candidate and hosted qualification gates.
Reuse the existing lifetime binary, bounded three-slot origin and canonical log reader. Retain request-start-relative budgets, delay collection through the paired provider scope, and verify original elapsed values against actual SDK body releases and causal source writes. Add negative controls for collection-stamped or coordinated early timing, missing releases and malformed protocol tails. All five root gates, 454 harness tests and the expanded 24-case local Fastly inventory pass. Keep exact-candidate and hosted qualification open.
Undo the changes from 14a6ca8, 658f89d, and 410a162 as one history-preserving revert. Preserve b97efec and all existing commits. This is a local comparison baseline; Aram is handling the public cleanup. No remote branch update is part of this commit. The five required Rust gates pass. Broader checks retain a pre-existing parallel fixture logger failure and reproduce the restored Fastly framing-receipt issue. Neither is hidden by this cleanup.
Prepare this change on an owned local follow-up for review. The parent is a temporary local revert baseline; publication and reconciliation onto the actual author-cleaned head are separate steps. Original-commit: 410a162
Prepare this change on an owned local follow-up for review. The parent is a temporary local revert baseline; publication and reconciliation onto the actual author-cleaned head are separate steps. Original-commit: 658f89d
Prepare this change on an owned local follow-up for review. The parent is a temporary local revert baseline; publication and reconciliation onto the actual author-cleaned head are separate steps. Original-commit: 14a6ca8
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and review order
Combine the existing demo framework work under one reproducible public SDK revision for the separate Trusted Server extraction.
Selected stack465 is ready for review: #275 → #406 → #407 → #409 → #414 → #422 → #439 → #454. This integration does not replace those reviews or merge any constituent into main. #454 remains a standalone prototype, not production KV Geo. CloudFront remains the demo serving provider.
Closes #461. Historical RC #431 and recovery refs remain preserved. Existing packaging/timing review units #401/#389 remain separate. No new buffer-group, codec-subset or phase-timeout experiment is included.
Exact checkpoint
Branch:
rc/aws-prospect-review-20261110.Integration commit:
456313675b6a85e11acea870240f6a6d869f1137.Tree:
3462994b652ac406fff8a93e2b0b36525e03876f.a7d7fd0f2face027e3810ed67e80f6341fcf68b69f090e573206cf0d8c21c1ce0067afffd69f12db8a2a0b7d7d268c6e2b7269dc49e02c47c5f04b8a5bbff2bf6d6d853b470f76e7293b7ecfa55476f5c66f93f118141a2ed7469a8ab96b12902f3854e6f9b0f20c6857d2e638bcfe7bf1edaa5af5425bfb414e52ae41ee95880fd11238a22ad2dc944f44c2c52bdaf34bb8694a6f2ee5b584ef127379db4cb0cec19886598c61e944e861c0515bb0f3ff4bb800b18a44d0a63790e8a16fe14737afa0a2053a5f5b96c21d731501370044f11ca5832e85701e79a4212510ecc91dbef4a6b6d6b8c725b63110773d69ba,7c07b8e777d9e0872c3bd9388df7ea7b2f189497The three follow-on review heads are explicit ancestors, not hidden conflict-resolution changes. #460 reuses the completed clock/readiness/tagged-platform-default unit directly required by TS callers; it does not include later optional SDK experiments. #453/MaxMind is excluded.
Retained fixes
Checks and limits
At this exact integration checkpoint, an isolated local build records:
native_source_bound_single_proxy_and_mapped_cidr_match_only_owned_peersreceived no expected handler client field, assertedNullversus127.0.0.1. This failure is unclassified and not waived. It prevents a clean hosting/readiness claim for this integration.The Core tree is unchanged from the earlier
7f9abacacheckpoint, which passed all six required commands, the legacy/docs guards and prototype checks. Those receipts remain bounded to their tested tree or unchanged relevant inputs; they are not a whole-workspace pass for this new checkpoint. An initial shared-target build had a source/artifact API mismatch; its failed logs were retained, and the isolated rebuild compiled the expected API without a source change.Fresh hosted results remain visible. No current complete workspace pass, TS compatibility, browser/consent, live ALB/CloudFront security, production identity persistence, fleet durability or deployment acceptance is claimed. The separate TS port must establish its own matching-pin checks.
No deployment, live input switch, registry publication, infrastructure mutation, old-RC retirement or recovery-ref deletion is authorized by this PR.
TS cutover follow-up, November 11
Integrates the refreshed existing stack and required conditional-record/finalization review heads. Preserves historical RC #431 and its semantic tag. This RC is the target for the next semantic Axum prerelease after hosted qualification.
Current head:
36f8e9c9c2c93661aaa73f2ca956cec3bc9e4c92.Local combined-RC qualification at
36f8e9c9c2c93661aaa73f2ca956cec3bc9e4c92: workspace tests 2,947 passed / 6 ignored; all-feature Axum 568 passed, including 36 production-hosting, 6 AWS startup and 4 celld startup cases; core doctests 19 passed / 13 ignored; strict workspace Clippy, formatting, feature compilation and Spin WASM check passed under Rust 1.98.1. Narrow TS consumer proof under Node 24.20.0: all four real proxy tests and typed prepared config/secrets/router startup passed. This is not final TS-stack/image/deployment qualification. Fresh hosted checks are still required.Current foundation and fixture checkpoint
Current RC source is
5d7c7fbe09503e3d76c42e2589f7705ac839be72. It retains concurrent #275 review closeoutb97efec1, the received-head/startup-router APIs, complete byte-bounded wire evidence and atomic framing receipts. The latest fixture-only repair is owned by #414 ate9181716; it fixes the reproduced AWS timeout test listener-lifetime race without changing production classification, timeouts or SDK retries.Predecessor
9e9da0c6passes all 13 local gates, including the full Fastly CI suite, with 2,947 workspace passes and 661 harness passes. Current RC workspace tests, strict AWS lint and formatting pass again. Its exact-head full Fastly recheck and fresh hosted checks are running. Local Fastly uses the explicitly repaired Viceroy, not a stock-runtime or hosted claim.The refreshed TS #1506 consumer includes
ff04dfb1and passes 4 proxy, 1 prepared config/secrets/router and 39 Axum route tests against9e9da0c6. This is a private path-overlay probe, not final tag-bound TS qualification. No new semantic tag, GitHub release, main merge or deployment has been performed.Latest RC qualification source
Current source is
4407d94130a9b752a70528b6c6f9c8fe3c10b81d, treeecf59797036cd36b6d9af411239dc6fe4ce0b479. It includes #275 callback-fixture repair14a6ca8bin addition to the preceding AWS fixture repair. Predecessor5d7c7fbereached 34 successful hosted checks; its remaining Fastly fixture failure was reproduced locally and corrected without changing production behavior or weakening stale-scope assertions. At the new RC, all 325 Fastly WASM unit tests, strict WASM Clippy and formatting pass. Full local Fastly CI and fresh hosted qualification are running. No new semantic tag or deployment is claimed.Owned follow-up review checkpoint
f4727dd6318ec1429aa9fe232ecb9b5ea8c9ac4e. Source treeecf59797036cd36b6d9af411239dc6fe4ce0b479is byte-identical to previous head4407d94130a9b752a70528b6c6f9c8fe3c10b81d.main. Existing tags, includingv0.0.12-rc-axum.202611.2at4407d941, are unchanged. No main merge, registry publication or deployment occurred.