Repository navigation
Expose JA4 through a standard request interface #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dhruv8sh
wants to merge
7
commits into
main
Choose a base branch
from
spec/283-ja4-request-interface
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,535
−22
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1d5bf2f
Add JA4 request interface design spec
dhruv8sh e373f0b
Expose JA4 through a standard request interface
dhruv8sh 0932b47
Record JA4 verification results in the implementation plan
dhruv8sh a3afa23
Cover JA4 on real runtimes and tidy the JA4 module
dhruv8sh 304f5a4
Read Axum JA4 from a trusted proxy header
dhruv8sh 516f976
Sync app-demo and reusable-app lockfiles with the Axum ipnet dependency
dhruv8sh 52f4a09
Name only AxumDevServer for the trusted JA4 header in the Axum guide
aram356 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛏ Nothing tests that
run_appreads the environment variables.I replaced this line with
let trusted_ja4_header: Option<TrustedJa4Header> = None;, and the Axum suite (131 tests) and the CLI suite still passed.from_envitself is unit-tested, and the PR description mentions a manualedgezero democheck.What isn't tested automatically is the documented operator path: set both variables and capture works, or set only one and startup fails. A small test through
run_apporserve_with_storeswith anEnvConfigwould cover it.