Repository navigation
Add REVIEW.md with review guidelines - #411
Open
vchamarthi wants to merge 5 commits into
Open
vchamarthi wants to merge 5 commits into
vchamarthi wants to merge 5 commits into
Conversation
Lists what a pull request must show before merge: NumPy/SciPy parity and layout/dtype edge cases, regression tests against an independent reference, measured performance evidence, C backend and packaging checks, changelog entries, and extra checks for automatically generated pull requests. Signed-off-by: vchamarthi <venkata.sai.gireesh.chamarthi@intel.com>
…ainer edits Signed-off-by: vchamarthi <venkata.sai.gireesh.chamarthi@intel.com>
vchamarthi
marked this pull request as ready for review
November 19, 2026 19:26
vchamarthi
requested review from
antonwolfy,
jharlow-intel,
ndgrigorian,
vlad-perevezentsev and
xaleryb
as code owners
November 19, 2026 19:26
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The changelog requirement conflicts with the prohibition on automated PRs editing CHANGELOG.md and omits the existing exemption for changes that are not user-visible.
1 open issue
What changed in this PR
Adds REVIEW.md as a review checklist alongside AGENTS.md, defining the evidence expected for changes to mkl_fft.
Changes:
- Defines correctness, testing, performance, backend, and packaging review checks.
- Adds extra checks for automated pull requests and policy-file edits.
- Sets expectations for changelog entries and pull request descriptions.
Repository verification was limited because /repo/AGENTS.md was unavailable.
| File | Description |
|---|---|
REVIEW.md |
Adds review guidelines for human and automated reviewers. |
Review effort: Balanced
Comment on lines
+115
to
+116
| - `CHANGELOG.md` has an entry under the `[dev]` section with a working link to the pull request and to | ||
| every issue it fixes. |
…ull requests - How to verify: build, test, lint, fail-on-base, A/A then ASV, and an unpatched NumPy reference. - Automated pull requests: detect by author and branch; the agent does not write CHANGELOG.md, a maintainer adds the entry; review the current state. - Correctness and tests: result memory order, input not modified, empty axes, longdouble, no duplicate tests, copyright header, stale asserts. - Pull request text: keep the exemption for changes that are not user-visible, follow the pull request template. - Rewritten as checks, under 100 lines. Signed-off-by: vchamarthi <venkata.sai.gireesh.chamarthi@intel.com>
Refer to the automation account, build commands, helper functions, benchmark names and changelog format by role or by their source of truth (CONTRIBUTING.md) instead of naming them. Signed-off-by: vchamarthi <venkata.sai.gireesh.chamarthi@intel.com>
Signed-off-by: vchamarthi <venkata.sai.gireesh.chamarthi@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds
REVIEW.md, the checklist reviewers (human and automated) apply tomkl_fftpull requests. It sits next toAGENTS.mdandCONTRIBUTING.md, which cover layout and coding rules. Each rule is written as a check a reviewer can apply to the diff.Sections:
out=direct-write check, stride/s=/axes=/norm/dtype edge cases,MKL_INToverflow,workerssemantics.mkl-service.CHANGELOG.md; a maintainer adds the entry before merge.The rules are drawn from review comments on past pull requests in this repository (#370, #382, #384, #387, #389, #396, #397).