Skip to content

Wait for every build before testing - #212

Open
jharlow-intel wants to merge 1 commit into
masterfrom
ci/tests-wait-all-builds
Open

jharlow-intel wants to merge 1 commit into
masterfrom
ci/tests-wait-all-builds

Conversation

@jharlow-intel

Copy link
Copy Markdown
Collaborator

The test and test-wheel jobs in intel-ci.yml now need both build jobs, build and build-wheel. Until now each one waited only for its own build job, so a failed wheel build still started the conda package tests, and a failed conda build still started the wheel tests.

A failed build already fails the run, so no test runners start for a run that can't go green, and they stay free for other runs in the queue. On a green run the tests start once both sets of builds have finished.

Validation: zizmor and pre-commit pass on the workflow. This pull request's own run exercises the green path; the failed-build path follows from how needs works and was not run.

The test jobs for the conda packages and the wheels now need both build jobs, so a run with any failed build starts no test runners.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant