Repository navigation
Port the test overview page to Vue - #4231
Open
williamjallen wants to merge 2 commits into
Open
williamjallen wants to merge 2 commits into
williamjallen wants to merge 2 commits into
Conversation
Adds Dusk tests for `testOverview.php` ahead of its Vue rewrite. They only use `data-test` hooks, which this change adds to the AngularJS template with no change in behavior, so the same tests can verify the rewrite. They cover the per-test failure and timeout statistics, build group and passing-test selection, sorting, paging, filters and navigation. No Cypress tests covered this page.
Rewrites `testOverview.php` from AngularJS to Vue. The page still loads its data from the legacy `testOverview` and `timeline` APIs and reuses the shared legacy filters, sorting, paging, calendar and timeline code from the earlier ports. Saved sort orders and page sizes in users' cookies keep working. The AngularJS controller and template are removed, along with the timeline directive that only this page used. The existing Dusk tests pass against the new page. A few bugs are fixed along the way. Each test's link to its runs used only the last day of a date range and didn't URL-encode the test or project name, so names containing characters like `&`, `#` or `+` broke the link. The link now carries the whole range and encodes both names. The Prev/Latest/Next links now keep "Include passing tests" as they already kept the build group.
Member
Author
|
Depends on #4228 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites
testOverview.phpfrom AngularJS to Vue. The page still loads its data from the legacytestOverviewandtimelineAPIs and reuses the shared legacy filters, sorting, paging, calendar and timeline code from the earlier ports. Saved sort orders and page sizes in users' cookies keep working. The AngularJS controller and template are removed, along with the timeline directive that only this page used.The existing Dusk tests pass against the new page. A few bugs are fixed along the way. Each test's link to its runs used only the last day of a date range and didn't URL-encode the test or project name, so names containing characters like
&,#or+broke the link. The link now carries the whole range and encodes both names. The Prev/Latest/Next links now keep "Include passing tests" as they already kept the build group.