Repository navigation
Conversation
grandixximo
reviewed
Nov 14, 2026
| if c.wait_complete() != linuxcnc.RCS_DONE: | ||
| canon.preview_incomplete = True | ||
| return | ||
| updated = AxisCanon(o, widgets.text, canon.linecount, DummyProgress(), arcdivision) |
Contributor
There was a problem hiding this comment.
With a program that is slow to parse (a 5M-iteration o100 while loop, about 9 s), Esc stops a normal load halfway, but this rebuild runs to the end: Esc at 2 s, done at 9.6 s. It has no progress bar, and cancel_open() sets aborted on o.canon, which is still the old preview here. Would a Progress and the same Esc binding as in open_file_guts() fit, so the rebuild can be cancelled and holds off input like a normal load?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AXIS redraws the coordinate axes when the active XY rotation changes, but the loaded program geometry still contains the rotation from its last parse. In the AXIS simulator, this is visible after homing and issuing
G10 L2 P1 R45in MDI with a program loaded.When MDI becomes idle after an XY rotation change, AXIS synchronizes the interpreter's parameter file and rebuilds the preview using the same program input, including cached filter output. The controller's open program and mode are preserved. Failed refreshes mark the preview incomplete so its extents are not presented as a complete check.
Fixes #498.
Validation
git diff --checkpassed.sim/axis, home the machine, load a program with an XY path that does not set its own coordinate rotation, and issueG10 L2 P1 R45in MDI while G54 is active. Both the axes and the preview should rotate after the command finishes.G10 L2 P1 R0should restore the original orientation without a manual reload.AI assistance was used to prepare the change and the local test harness.