Repository navigation
Compact filter panel spacing - #752
Open
Pr0metheus2 wants to merge 2 commits into
Open
Pr0metheus2 wants to merge 2 commits into
Pr0metheus2 wants to merge 2 commits into
Conversation
## Summary Reduces unused vertical space in the filter UI. - The Advanced / ProFilter section now sizes itself to its actual controls instead of reserving a fixed 110 px height. - The F4 Text filter row is reduced from 46 px to 41 px, leaving only a minimal bottom margin. - The content below the Text filter row moves up accordingly. ## Verification - Built `LogExpert.UI` in Debug configuration successfully. - Checked manually that the Advanced and F4 filter areas have less unused space.
Member
|
This must be tested with High and Low DPI as well, because this will 100% make problems on High DPI monitors, with the standard windows settings |
Contributor
Author
|
You are right: the fixed 41 px F4 row is DPI-sensitive. |
Member
|
yeah its super annoying |
Improves the Text Filter / F4 panel layout and removes unnecessary vertical space. - Sizes the Advanced/ProFilter area from its actual content instead of a fixed splitter position. - Reduces unused space around the F4 Text Filter and Advanced panels. - Keeps Search, filter checkboxes, and Show advanced compact and visible at high DPI (including 200%). - Uses consistent checkbox spacing without scaling empty gaps with DPI. - Recalculates the layout after DPI changes and once initial control scaling has completed. - Aligns all fields in F4 row vertically Verification: - Built LogExpert.UI Debug successfully (0 errors). - Manually checked at 100%, 150%, and 200% display scaling.
Contributor
Author
Improve F4 filter-panel layout at high DPIImproves the Text Filter / F4 panel layout and removes unnecessary vertical space.
Verification:
|
Hirogen
requested changes
Nov 20, 2026
Hirogen
left a comment
Member
There was a problem hiding this comment.
Thanks, the tighter filter panel looks much better, and sizing the Advanced area from its real content instead of the hard-coded 110 is the right idea. A few things before we can merge:
Must fix
- Please revert
src/setup/GeneratedFiles.iss. It's generated by the NukeGenerateInstallerFileListtarget fromLogExpert.deps.json(see the header). The six DLLs removed here are still in deps.json;System.Drawing.CommonandSystem.Resources.Extensionsare direct package references.InstallerCoverageTests.Installer_ShipsEveryRuntimeAssembly_DeclaredInDepsJsonchecks the committed file, so I'd expect it to fail. This probably came from a local build regenerating it. - Guard the splitter assignments.
SetAdvancedFilterSplitterDistancesetsadvancedFilterSplitContainer.SplitterDistancedirectly.SplitContainerthrows (it doesn't clamp) when the value breaks Panel1/Panel2MinSize or the container size, and this container is Dock=Fill. The value now grows with DPI (about 160 px at 200%) and the method now also runs on DPI change, Load and everysplitContainerLogWindowmove, so a short window can crash. Please go throughFilterSplitterLayout.TryClampSplitterDistancelikeAutoResizeFilterBoxdoes. The same risk applies to the newfilterSplitContainer.Panel1MinSizeassignment inLayoutFilterControls. advancedBackPanelonly gets itsTopchanged. It's anchored Top|Bottom|Left|Right, so moving it up 5 px without growing it leaves a 5 px empty strip at the bottom. Please adjust the height as well (e.g. viaBounds).
Should fix
- Vertical alignment: the checkboxes are centred on the Search button and the label on the checkboxes, but
filterComboBoxstays at Top=5, so "Text filter:" now sits about 7 px lower than its combo box. Centring the label (and the combo /btnAdvanced) on the same line would match "aligns all fields". - Don't repeat the relayout block:
OnDpiChangedAfterParentandOnLogWindowLoadcall the same four methods; please pull them into one method. The constructor call toSetFilterInputPanelHeight()runs before scaling and looks unnecessary. - Small things:
lblTextFilter.AutoSize = trueduplicates the designer.FILTER_PANEL2_CONTROL_GAPis now also used in Panel1, so a more general name would fit. Why the gap changed from 6 to 7?Panel1MinSizedropping from 200 to about 165 lets the filter box shrink further; intended? Please keep the final newlines inLogWindow.csandLogWindow.designer.cs.
Nice to have
- The spacing/centring maths in
LayoutFilterControlsis pure arithmetic. Pulling it intoFilterSplitterLayout(or a sibling) would let it be unit-tested next toFilterSplitterLayoutTests.
Thanks again for your hard work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The Advanced split container have unused extra space reserving 110 px for a ProFilter panel that is only 80 px high. Also, the F4 Text filter row has unused space at the bottom, which needs to be decreased.
Before change:

After change:

Summary
Reduces unused vertical space in the filter UI.
Verification
LogExpert.UIin Debug configuration successfully.