Repository navigation
Load agent steering from the repo root and add format and resx checks - #753
Merged
Merged
Conversation
- Root CLAUDE.md with project facts; Claude Code never loaded .github/CLAUDE.md. Generic agent rules move to .github/agent-guidelines.md. - docs/CODING_STANDARDS.md for review-time rules (no XML docs on internal/private members), tracked via a .gitignore exception. - CI: dotnet format whitespace check on the C# files a PR changes, and tools/Test-ResxKeyParity.ps1 for en/de/zh-CN key parity. - Resources.de.resx: add the three missing ColumnizerMask column keys. - src/.editorconfig: ReSharper final-newline setting now matches insert_final_newline = false. - devcontainer sets core.hooksPath to .githooks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.md: Claude Code only auto-loadsCLAUDE.mdfrom the repo root, so.github/CLAUDE.mdnever loaded. The root file holds project facts (build/test, gotchas, real paths such assrc/.editorconfig, flaky UI test notes). Generic agent behaviour rules moved to.github/agent-guidelines.md;.github/CLAUDE.mdis now a pointer.docs/CODING_STANDARDS.md: review-time judgement rules, starting with "no XML doc comments on internal/private members or test classes" (matchesCS1591 = none)..gitignoregets!/docs/CODING_STANDARDS.mdso it is tracked.test_dotnet.yml):dotnet format whitespace --verify-no-changeson thesrc/*.csfiles a PR changes (the whole solution has 476 existing violations, so it is scoped to changed files;fetch-depth: 2).tools/Test-ResxKeyParity.ps1: fails when en/de/zh-CN resource keys differ.Resources.de.resx: the parity check found three missingSettingsDialog_UI_DataGridView_*ColumnizerMask*keys; German translations added. Please check the wording.src/.editorconfig:resharper_csharp_insert_final_newlinenow agrees withinsert_final_newline = false(349 vs 292 tracked files).postCreateCommandsetscore.hooksPath .githooksso the commit-msg hook is active.Test plan
tools/Test-ResxKeyParity.ps1→ "Resx key parity OK".githooks/commit-msgon a sample message strips trailers, keeps issue links.resx/config, so no C# files are checked)