Skip to content

Load agent steering from the repo root and add format and resx checks - #753

Merged
Hirogen merged 1 commit into
Developmentfrom
chore/agent-steering-and-checks
Nov 19, 2026
Merged

Hirogen merged 1 commit into
Developmentfrom
chore/agent-steering-and-checks

Conversation

@Hirogen

@Hirogen Hirogen commented Nov 19, 2026

Copy link
Copy Markdown
Member

Summary

  • Root CLAUDE.md: Claude Code only auto-loads CLAUDE.md from the repo root, so .github/CLAUDE.md never loaded. The root file holds project facts (build/test, gotchas, real paths such as src/.editorconfig, flaky UI test notes). Generic agent behaviour rules moved to .github/agent-guidelines.md; .github/CLAUDE.md is now a pointer.
  • docs/CODING_STANDARDS.md: review-time judgement rules, starting with "no XML doc comments on internal/private members or test classes" (matches CS1591 = none). .gitignore gets !/docs/CODING_STANDARDS.md so it is tracked.
  • CI (test_dotnet.yml):
    • dotnet format whitespace --verify-no-changes on the src/*.cs files a PR changes (the whole solution has 476 existing violations, so it is scoped to changed files; fetch-depth: 2).
    • tools/Test-ResxKeyParity.ps1: fails when en/de/zh-CN resource keys differ.
  • Resources.de.resx: the parity check found three missing SettingsDialog_UI_DataGridView_*ColumnizerMask* keys; German translations added. Please check the wording.
  • src/.editorconfig: resharper_csharp_insert_final_newline now agrees with insert_final_newline = false (349 vs 292 tracked files).
  • devcontainer: postCreateCommand sets core.hooksPath .githooks so the commit-msg hook is active.

Test plan

  • tools/Test-ResxKeyParity.ps1 → "Resx key parity OK"
  • .githooks/commit-msg on a sample message strips trailers, keeps issue links
  • CI format step on this PR (touches only .resx/config, so no C# files are checked)

- Root CLAUDE.md with project facts; Claude Code never loaded
  .github/CLAUDE.md. Generic agent rules move to .github/agent-guidelines.md.
- docs/CODING_STANDARDS.md for review-time rules (no XML docs on
  internal/private members), tracked via a .gitignore exception.
- CI: dotnet format whitespace check on the C# files a PR changes, and
  tools/Test-ResxKeyParity.ps1 for en/de/zh-CN key parity.
- Resources.de.resx: add the three missing ColumnizerMask column keys.
- src/.editorconfig: ReSharper final-newline setting now matches
  insert_final_newline = false.
- devcontainer sets core.hooksPath to .githooks.
@Hirogen
Hirogen merged commit c6b9923 into Development Nov 19, 2026
3 checks passed
@Hirogen
Hirogen deleted the chore/agent-steering-and-checks branch November 19, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant