Repository navigation
Conversation
…ve (#713) The nonzero-offset branch of SquareBracketColumnizer.SplitLine split only the reformatted timestamp, so all columns after the time came back empty. Rebuild the line from the shifted timestamp plus the original suffix before splitting.
Member
Author
|
duplicated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the Square Bracket Columnizer had a nonzero time offset,
SplitLinereturned the shifted date and time but empty values for every bracket field and the message. The offset branch passed only the reformatted timestamp toSquareSplitand discarded the rest of the line. With offset 0 the columns were correct.The fix rebuilds the line from the shifted timestamp plus the original text after it, then splits that. The zero-offset path and
SquareSplitare unchanged.Tests
Added to
SquareBracketColumnizerTest(written first; they failed before the fix):SplitLine_TimeOffset_KeepsBracketFieldsAndMessage: offsets 0, +123 ms, −1505 ms, and a date rollover forward and backward. Each case checks all five columns.SplitLine_TimeOffsetResetToZero_RestoresOriginalColumns: setting the offset back to 0 restores the original columns, and the log line is never changed.Square Bracket and marker-snapshot tests: 16/16 pass.